build: Use a PHP-CS-Fixer shim rather than an external PHAR

Author: theofidry

composer.json

@@ -16,6 +16,7 @@
         "php": ">=8.1",
         "doctrine/inflector": "^2.0",
         "nikic/php-parser": "^4.18|^5.0",
+        "php-cs-fixer/shim": "^v3.59.3",
         "symfony/config": "^6.4|^7.0",
         "symfony/console": "^6.4|^7.0",
         "symfony/dependency-injection": "^6.4|^7.0",

src/Resources/bin/php-cs-fixer-v3.49.0.phar

@@ -25,9 +25,6 @@
  */
 final class TemplateLinter
 {
-    // Version must match bundled version file name. e.g. php-cs-fixer-v3.49.9.phar
-    public const BUNDLED_PHP_CS_FIXER_VERSION = '3.49.0';
-
     private bool $usingBundledPhpCsFixer = true;
     private bool $usingBundledPhpCsFixerConfig = true;
     private bool $needsPhpCmdPrefix = true;
@@ -99,7 +96,18 @@ private function setBinary(): void
     {
         // Use Bundled PHP-CS-Fixer
         if (null === $this->phpCsFixerBinaryPath) {
-            $this->phpCsFixerBinaryPath = sprintf('%s/Resources/bin/php-cs-fixer-v%s.phar', \dirname(__DIR__), self::BUNDLED_PHP_CS_FIXER_VERSION);
+            $pathCandidates = [
+                __DIR__.'/../../vendor/php-cs-fixer/shim/php-cs-fixer',
+                __DIR__.'/../../../php-cs-fixer/shim/php-cs-fixer',
+            ];
+
+            foreach ($pathCandidates as $pathCandidate) {
+                if (is_file($pathCandidate)) {
+                    $this->phpCsFixerBinaryPath = $pathCandidate;
+
+                    return;
+                }
+            }
 
             return;
         }

src/Util/TemplateLinter.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Bundle\MakerBundle\Tests\Util;
 
+use Composer\InstalledVersions;
 use PHPUnit\Framework\TestCase;
 use Symfony\Bundle\MakerBundle\Util\TemplateLinter;
 use Symfony\Component\Process\Process;
@@ -44,12 +45,13 @@ public function testPhpCsFixerVersion(): void
             $this->markTestSkipped('Test only runs on linux.');
         }
 
-        $fixerPath = sprintf('%s/src/Resources/bin/php-cs-fixer-v%s.phar', \dirname(__DIR__, 2), TemplateLinter::BUNDLED_PHP_CS_FIXER_VERSION);
+        $fixerPath = __DIR__.'/../../vendor/php-cs-fixer/shim/php-cs-fixer';
+        $expectedVersion = InstalledVersions::getVersion('php-cs-fixer/shim');
 
         $process = Process::fromShellCommandline(sprintf('%s -V', $fixerPath));
 
         $process->run();
 
-        self::assertStringContainsString(TemplateLinter::BUNDLED_PHP_CS_FIXER_VERSION, $process->getOutput());
+        self::assertStringContainsString($expectedVersion, $process->getOutput());
     }
 }