bug #295 [Voter] Use the subject's FQCN in the support method (lyrixx)

weaverryan · weaverryan · commit 407a7483a96c · 2018-10-23T14:30:49.000-04:00
This PR was merged into the 1.0-dev branch. Discussion ---------- [Voter] Use the subject's FQCN in the support method People could replace only the `BlogPost` class. So the support method will always return `false`. With a leading `\`, the class name will resolve "normally" Commits ------- 651ee9a [Voter] Use the subject's FQCN in the support method
diff --git a/src/Resources/skeleton/security/Voter.tpl.php b/src/Resources/skeleton/security/Voter.tpl.php
@@ -13,7 +13,7 @@ protected function supports($attribute, $subject)
         // replace with your own logic
         // https://symfony.com/doc/current/security/voters.html
         return in_array($attribute, ['POST_EDIT', 'POST_VIEW'])
-            && $subject instanceof App\Entity\BlogPost;
+            && $subject instanceof \App\Entity\BlogPost;
     }
 
     protected function voteOnAttribute($attribute, $subject, TokenInterface $token)

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ protected function supports($attribute, $subject)`
`13`	`13`	`// replace with your own logic`
`14`	`14`	`// https://symfony.com/doc/current/security/voters.html`
`15`	`15`	`return in_array($attribute, ['POST_EDIT', 'POST_VIEW'])`
`16`		`- && $subject instanceof App\Entity\BlogPost;`
	`16`	`+ && $subject instanceof \App\Entity\BlogPost;`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`protected function voteOnAttribute($attribute, $subject, TokenInterface $token)`