strict typing

Author: jrushlow

src/Maker/MakeSubscriber.php

@@ -121,10 +121,7 @@ public function configureDependencies(DependencyBuilder $dependencies): void
     {
     }
 
-    /**
-     * @param $event
-     */
-    private function getEventConstant($event): string
+    private function getEventConstant(string $event): string
     {
         $constants = $this->getKernelEventsConstants();
 
@@ -137,10 +134,7 @@ private function getEventConstant($event): string
         return sprintf('\'%s\'', $event);
     }
 
-    /**
-     * @param $event
-     */
-    private function isNeedImportConstantsClass($event): bool
+    private function isNeedImportConstantsClass(string $event): bool
     {
         $constants = $this->getKernelEventsConstants();
 
@@ -155,8 +149,6 @@ private function isNeedImportConstantsClass($event): bool
 
     private function getKernelEventsConstants(): array
     {
-        $class = new \ReflectionClass(KernelEvents::class);
-
-        return $class->getConstants();
+        return (new \ReflectionClass(KernelEvents::class))->getConstants();
     }
 }

tests/Maker/MakeSubscriberTest.php

@@ -22,7 +22,7 @@ protected function getMakerClass(): string
         return MakeSubscriber::class;
     }
 
-    public function getTestDetails()
+    public function getTestDetails(): \Generator
     {
         yield 'it_makes_subscriber_for_known_event' => [$this->createMakerTest()
             ->run(function (MakerTestRunner $runner) {