bug #1728 PHP 8.4 Deprecation Fix (natewiebe13)

javiereguiluz · javiereguiluz · commit 6f42db1f6b52 · 2025-11-24T16:40:17.000+01:00
This PR was merged into the 1.x branch. Discussion ---------- PHP 8.4 Deprecation Fix Resolves the following deprecation: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types Commits ------- 0bbc9c1 Update arg type to be nullable
diff --git a/templates/resetPassword/ResetPasswordController.tpl.php b/templates/resetPassword/ResetPasswordController.tpl.php
@@ -57,7 +57,7 @@ public function checkEmail(): Response
      * Validates and process the reset URL that the user clicked in their email.
      */
     #[Route('/reset/{token}', name: 'app_reset_password')]
-    public function reset(Request $request, UserPasswordHasherInterface $passwordHasher<?php if ($translator_available): ?>, TranslatorInterface $translator<?php endif ?>, string $token = null): Response
+    public function reset(Request $request, UserPasswordHasherInterface $passwordHasher<?php if ($translator_available): ?>, TranslatorInterface $translator<?php endif ?>, ?string $token = null): Response
     {
         if ($token) {
             // We store the token in session and remove it from the URL, to avoid the URL being

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public function checkEmail(): Response`
`57`	`57`	`* Validates and process the reset URL that the user clicked in their email.`
`58`	`58`	`*/`
`59`	`59`	`#[Route('/reset/{token}', name: 'app_reset_password')]`
`60`		`- public function reset(Request $request, UserPasswordHasherInterface $passwordHasher<?php if ($translator_available): ?>, TranslatorInterface $translator<?php endif ?>, string $token = null): Response`
	`60`	`+ public function reset(Request $request, UserPasswordHasherInterface $passwordHasher<?php if ($translator_available): ?>, TranslatorInterface $translator<?php endif ?>, ?string $token = null): Response`
`61`	`61`	`{`
`62`	`62`	`if ($token) {`
`63`	`63`	`// We store the token in session and remove it from the URL, to avoid the URL being`