feature #280 Add --no-template option for make:controller command (welcoMattic)

This PR was squashed before being merged into the 1.0-dev branch (closes #280).

Discussion
----------

Add --no-template option for make:controller command

I had several times the case in which I did not necessarily need a template when I generated a controller. So I'm trying to add an option `--no-template` to force avoid template generation.

I think that I will need help on tests writing ;)

Commits
-------

99680bc Fix tests (passed on local env)
d6ec857 Fix internal project tests
052734c Try to fix tests
860d340 WIP Add --no-template option for make:controller command

Author: weaverryan

src/Maker/MakeController.php

@@ -21,6 +21,7 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
 
 /**
  * @author Javier Eguiluz <[email protected]>
@@ -38,6 +39,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
         $command
             ->setDescription('Creates a new controller class')
             ->addArgument('controller-class', InputArgument::OPTIONAL, sprintf('Choose a name for your controller class (e.g. <fg=yellow>%sController</>)', Str::asClassName(Str::getRandomTerm())))
+            ->addOption('no-template', null, InputOption::VALUE_NONE, 'Use this option to disable template generation')
             ->setHelp(file_get_contents(__DIR__.'/../Resources/help/MakeController.txt'))
         ;
     }
@@ -50,19 +52,20 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             'Controller'
         );
 
+        $noTemplate = $input->getOption('no-template');
         $templateName = Str::asFilePath($controllerClassNameDetails->getRelativeNameWithoutSuffix()).'/index.html.twig';
         $controllerPath = $generator->generateController(
             $controllerClassNameDetails->getFullName(),
             'controller/Controller.tpl.php',
             [
                 'route_path' => Str::asRoutePath($controllerClassNameDetails->getRelativeNameWithoutSuffix()),
                 'route_name' => Str::asRouteName($controllerClassNameDetails->getRelativeNameWithoutSuffix()),
-                'twig_installed' => $this->isTwigInstalled(),
+                'with_template' => $this->isTwigInstalled() && !$noTemplate,
                 'template_name' => $templateName,
             ]
         );
 
-        if ($this->isTwigInstalled()) {
+        if ($this->isTwigInstalled() && !$noTemplate) {
             $generator->generateFile(
                 'templates/'.$templateName,
                 'controller/twig_template.tpl.php',

src/Resources/help/MakeController.txt

@@ -3,3 +3,7 @@ The <info>%command.name%</info> command generates a new controller class.
 <info>php %command.full_name% CoolStuffController</info>
 
 If the argument is missing, the command will ask for the controller class name interactively.
+
+You can also generate the controller alone, without template with this option:
+
+<info>php %command.full_name% --no-template</info>

src/Resources/skeleton/controller/Controller.tpl.php

@@ -12,7 +12,7 @@ class <?= $class_name; ?> extends <?= $parent_class_name; ?><?= "\n" ?>
      */
     public function index()
     {
-<?php if ($twig_installed) { ?>
+<?php if ($with_template) { ?>
         return $this->render('<?= $template_name ?>', [
             'controller_name' => '<?= $class_name ?>',
         ]);

tests/Maker/FunctionalTest.php

@@ -121,6 +121,22 @@ public function getCommandTests()
             ->deleteFile('templates/base.html.twig')
         ];
 
+        yield 'controller_without_template' => [MakerTestDetails::createTest(
+            $this->getMakerInstance(MakeController::class),
+            [
+                // controller class name
+                'FooNoTemplate',
+            ])
+            ->setArgumentsString('--no-template')
+            ->addExtraDependencies('twig')
+            ->assert(function (string $output, string $directory) {
+                // make sure the template was not configured
+                $this->assertContainsCount('created: ', $output, 1);
+                $this->assertContains('created: src/Controller/FooNoTemplateController.php', $output);
+                $this->assertNotContains('created: templates/foo_no_template/index.html.twig', $output);
+            })
+        ];
+
         yield 'controller_sub_namespace' => [MakerTestDetails::createTest(
             $this->getMakerInstance(MakeController::class),
             [