feature #963 add return types for symfony 6 (jrushlow)

This PR was squashed before being merged into the 1.0-dev branch.

Discussion
----------

add return types for symfony 6

- adds return types required to support Symfony 6

Also implements return types in other areas of the bundle as well.

Methodology:
- `internal` xor `final` classes return types added on all methods where possible
- All other classes, deprecation(s) to be added under a separate PR for methods that do not have a return type. return types to be added in the next major release.

Commits
-------

2c0ad1e add return types for symfony 6

Author: weaverryan

src/Command/MakerCommand.php

@@ -50,12 +50,12 @@ public function __construct(MakerInterface $maker, FileManager $fileManager, Gen
         parent::__construct();
     }
 
-    protected function configure()
+    protected function configure(): void
     {
         $this->maker->configureCommand($this, $this->inputConfig);
     }
 
-    protected function initialize(InputInterface $input, OutputInterface $output)
+    protected function initialize(InputInterface $input, OutputInterface $output): void
     {
         $this->io = new ConsoleStyle($input, $output);
         $this->fileManager->setIO($this->io);
@@ -74,7 +74,7 @@ protected function initialize(InputInterface $input, OutputInterface $output)
         }
     }
 
-    protected function interact(InputInterface $input, OutputInterface $output)
+    protected function interact(InputInterface $input, OutputInterface $output): void
     {
         if (!$this->fileManager->isNamespaceConfiguredToAutoload($this->generator->getRootNamespace())) {
             $this->io->note([
@@ -111,7 +111,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return 0;
     }
 
-    public function setApplication(Application $application = null)
+    public function setApplication(Application $application = null): void
     {
         parent::setApplication($application);
 
@@ -127,7 +127,7 @@ public function setApplication(Application $application = null)
     /**
      * @internal Used for testing commands
      */
-    public function setCheckDependencies(bool $checkDeps)
+    public function setCheckDependencies(bool $checkDeps): void
     {
         $this->checkDependencies = $checkDeps;
     }

src/ConsoleStyle.php

@@ -30,12 +30,12 @@ public function __construct(InputInterface $input, OutputInterface $output)
         parent::__construct($input, $output);
     }
 
-    public function success($message)
+    public function success($message): void
     {
         $this->writeln('<fg=green;options=bold,underscore>OK</> '.$message);
     }
 
-    public function comment($message)
+    public function comment($message): void
     {
         $this->text($message);
     }

src/DependencyBuilder.php

@@ -25,7 +25,7 @@ final class DependencyBuilder
      * the user if other required dependencies are missing. An example
      * is the "validator" when trying to work with forms.
      */
-    public function addClassDependency(string $class, string $package, bool $required = true, bool $devDependency = false)
+    public function addClassDependency(string $class, string $package, bool $required = true, bool $devDependency = false): void
     {
         if ($devDependency) {
             $this->devDependencies[] = [
@@ -42,7 +42,7 @@ public function addClassDependency(string $class, string $package, bool $require
         }
     }
 
-    public function requirePHP71()
+    public function requirePHP71(): void
     {
         // no-op - MakerBundle now required PHP 7.1
     }

src/DependencyInjection/CompilerPass/MakeCommandRegistrationPass.php

@@ -25,7 +25,7 @@ class MakeCommandRegistrationPass implements CompilerPassInterface
 {
     public const MAKER_TAG = 'maker.command';
 
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         foreach ($container->findTaggedServiceIds(self::MAKER_TAG) as $id => $tags) {
             $def = $container->getDefinition($id);

src/DependencyInjection/CompilerPass/RemoveMissingParametersPass.php

@@ -21,7 +21,7 @@
  */
 class RemoveMissingParametersPass implements CompilerPassInterface
 {
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         if (!$container->hasParameter('twig.default_path')) {
             $container->getDefinition('maker.file_manager')

src/DependencyInjection/CompilerPass/SetDoctrineAnnotatedPrefixesPass.php

@@ -20,7 +20,7 @@
 
 class SetDoctrineAnnotatedPrefixesPass implements CompilerPassInterface
 {
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         $annotatedPrefixes = null;
 

src/DependencyInjection/CompilerPass/SetDoctrineManagerRegistryClassPass.php

@@ -20,7 +20,7 @@
  */
 class SetDoctrineManagerRegistryClassPass implements CompilerPassInterface
 {
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         if ($container->hasAlias(ManagerRegistry::class)) {
             $definition = $container->getDefinition('maker.entity_class_generator');

src/DependencyInjection/Configuration.php

@@ -19,7 +19,7 @@ class Configuration implements ConfigurationInterface
     /**
      * {@inheritdoc}
      */
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('maker');
         if (method_exists($treeBuilder, 'getRootNode')) {

src/DependencyInjection/MakerExtension.php

@@ -34,7 +34,7 @@ class MakerExtension extends Extension
     /**
      * {@inheritdoc}
      */
-    public function load(array $configs, ContainerBuilder $container)
+    public function load(array $configs, ContainerBuilder $container): void
     {
         $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services.xml');

src/Doctrine/BaseRelation.php

@@ -26,36 +26,36 @@ abstract class BaseRelation
 
     abstract public function isOwning(): bool;
 
-    public function getPropertyName()
+    public function getPropertyName(): string
     {
         return $this->propertyName;
     }
 
-    public function setPropertyName($propertyName)
+    public function setPropertyName(string $propertyName): self
     {
         $this->propertyName = $propertyName;
 
         return $this;
     }
 
-    public function getTargetClassName()
+    public function getTargetClassName(): string
     {
         return $this->targetClassName;
     }
 
-    public function setTargetClassName($targetClassName)
+    public function setTargetClassName(string $targetClassName): self
     {
         $this->targetClassName = $targetClassName;
 
         return $this;
     }
 
-    public function getTargetPropertyName()
+    public function getTargetPropertyName(): ?string
     {
         return $this->targetPropertyName;
     }
 
-    public function setTargetPropertyName($targetPropertyName)
+    public function setTargetPropertyName(?string $targetPropertyName): self
     {
         $this->targetPropertyName = $targetPropertyName;
 
@@ -67,7 +67,7 @@ public function isSelfReferencing(): bool
         return $this->isSelfReferencing;
     }
 
-    public function setIsSelfReferencing(bool $isSelfReferencing)
+    public function setIsSelfReferencing(bool $isSelfReferencing): self
     {
         $this->isSelfReferencing = $isSelfReferencing;
 
@@ -79,7 +79,7 @@ public function getMapInverseRelation(): bool
         return $this->mapInverseRelation;
     }
 
-    public function setMapInverseRelation(bool $mapInverseRelation)
+    public function setMapInverseRelation(bool $mapInverseRelation): self
     {
         $this->mapInverseRelation = $mapInverseRelation;
 
@@ -91,7 +91,7 @@ public function shouldAvoidSetter(): bool
         return $this->avoidSetter;
     }
 
-    public function avoidSetter(bool $avoidSetter = true)
+    public function avoidSetter(bool $avoidSetter = true): self
     {
         $this->avoidSetter = $avoidSetter;