Fixing bug where non-traditional User class broke in make:user

Author: weaverryan

src/Maker/MakeUser.php

@@ -159,7 +159,10 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             $userClassConfiguration->setUserProviderClass('App\\Security\\UserProvider');
             $customProviderPath = $generator->generateClass(
                 $userClassConfiguration->getUserProviderClass(),
-                'security/UserProvider.tpl.php'
+                'security/UserProvider.tpl.php',
+                [
+                    'user_short_name' => $userClassNameDetails->getShortName(),
+                ]
             );
         }
 

src/Resources/skeleton/security/UserProvider.tpl.php

@@ -42,11 +42,11 @@ public function loadUserByUsername($username)
      */
     public function refreshUser(UserInterface $user)
     {
-        if (!$user instanceof User) {
+        if (!$user instanceof <?= $user_short_name ?>) {
             throw new UnsupportedUserException(sprintf('Invalid user class "%s".', get_class($user)));
         }
 
-        /* @var User $user */
+        /* @var <?= $user_short_name ?> $user */
 
         // Return a User object after making sure its data is "fresh".
         // Or throw a UsernameNotFoundException if the user no longer exists.
@@ -58,6 +58,6 @@ public function refreshUser(UserInterface $user)
      */
     public function supportsClass($class)
     {
-        return User::class === $class;
+        return <?= $user_short_name ?>::class === $class;
     }
 }

tests/Maker/FunctionalTest.php

@@ -544,8 +544,8 @@ function (string $output, string $directory) {
         yield 'user_security_model_no_password' => [MakerTestDetails::createTest(
             $this->getMakerInstance(MakeUser::class),
             [
-                // user class name
-                'User',
+                // user class name (with non-traditional name)
+                'FunUser',
                 'n', // entity
                 'username', // identity property
                 'n', // login with password?

tests/fixtures/MakeUserModelNoPassword/src/Security/AutomaticAuthenticator.php

@@ -32,7 +32,7 @@ public function getCredentials(Request $request)
 
     public function getUser($credentials, UserProviderInterface $userProvider)
     {
-        $user = new User();
+        $user = new FunUser();
         $user->setUsername($credentials);
 
         return $user;