feature #1332 Add conditional @implements tag to Doctrine repository template (gremo)

weaverryan · weaverryan · commit 9907779eaa8c · 2023-07-10T13:06:43.000-04:00
This PR was merged into the 1.0-dev branch. Discussion ---------- Add conditional `@implements` tag to Doctrine repository template Adding the `@implements` phpdoc tag on generated Doctrine repository classes will help IDE and prevent tools like phpstan from generating errors. `@implements` is only added if `$with_password_upgrade` is set to true, avoiding useless phpdocs. ![Immagine 2023-07-06 120413](https://github.com/symfony/maker-bundle/assets/1532616/9e9c1b08-4f60-4a8b-862d-0f32cff2920b) Similar to #1088 Commits ------- dd3208f Add conditional `@implements` tag to Doctrine repository template
diff --git a/src/Resources/skeleton/doctrine/Repository.tpl.php b/src/Resources/skeleton/doctrine/Repository.tpl.php
@@ -6,6 +6,7 @@
 
 /**
  * @extends ServiceEntityRepository<<?= $entity_class_name; ?>>
+<?= $with_password_upgrade ? "* @implements PasswordUpgraderInterface<$entity_class_name>\n" : "" ?>
  *
  * @method <?= $entity_class_name; ?>|null find($id, $lockMode = null, $lockVersion = null)
  * @method <?= $entity_class_name; ?>|null findOneBy(array $criteria, array $orderBy = null)

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`
`7`	`7`	`/**`
`8`	`8`	`* @extends ServiceEntityRepository<<?= $entity_class_name; ?>>`
	`9`	`+<?= $with_password_upgrade ? "* @implements PasswordUpgraderInterface<$entity_class_name>\n" : "" ?>`
`9`	`10`	`*`
`10`	`11`	`* @method <?= $entity_class_name; ?>\|null find($id, $lockMode = null, $lockVersion = null)`
`11`	`12`	`* @method <?= $entity_class_name; ?>\|null findOneBy(array $criteria, array $orderBy = null)`