Test logging process with users as entity

Author: nikophil

tests/Maker/FunctionalTest.php

@@ -16,7 +16,6 @@
 use Symfony\Bundle\MakerBundle\Maker\MakeFixtures;
 use Symfony\Bundle\MakerBundle\Maker\MakeForm;
 use Symfony\Bundle\MakerBundle\Maker\MakeFunctionalTest;
-use Symfony\Bundle\MakerBundle\Maker\MakeLoginForm;
 use Symfony\Bundle\MakerBundle\Maker\MakeMigration;
 use Symfony\Bundle\MakerBundle\Maker\MakeSerializerEncoder;
 use Symfony\Bundle\MakerBundle\Maker\MakeSubscriber;
@@ -396,34 +395,40 @@ function (string $output, string $directory) {
                 ),
         ];
 
-        yield 'auth_login_form_user_entity' => [
-            MakerTestDetails::createTest(
-                $this->getMakerInstance(MakeAuthenticator::class),
-                [
-                    // authenticator type => login-form
-                    1,
-                    // class name
-                    'AppCustomAuthenticator',
-                    // controller name
-                    'SecurityController'
-                ]
-            )
-                ->addExtraDependencies('doctrine')
-                ->addExtraDependencies('security')
-                ->addExtraDependencies('twig')
-                ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeAuthenticatorLoginFormUserEntity')
-                ->configureDatabase()
-                ->updateSchemaAfterCommand()
-                ->assert(
-                    function (string $output, string $directory) {
-                        $this->assertContains('Success', $output);
+        $makerTestAuthenticatorLoginFormUserEntity = MakerTestDetails::createTest(
+            $this->getMakerInstance(MakeAuthenticator::class),
+            [
+                // authenticator type => login-form
+                1,
+                // class name
+                'AppCustomAuthenticator',
+                // controller name
+                'SecurityController',
+            ]
+        )
+            ->addExtraDependencies('doctrine')
+            ->addExtraDependencies('security')
+            ->addExtraDependencies('twig')
+            ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeAuthenticatorLoginFormUserEntity')
+            ->configureDatabase()
+            ->updateSchemaAfterCommand()
+            ->assert(
+                function (string $output, string $directory) {
+                    $this->assertContains('Success', $output);
+
+                    $fs = new Filesystem();
+                    $this->assertTrue($fs->exists(sprintf('%s/src/Controller/SecurityController.php', $directory)));
+                    $this->assertTrue($fs->exists(sprintf('%s/templates/security/login.html.twig', $directory)));
+                    $this->assertTrue($fs->exists(sprintf('%s/src/Security/AppCustomAuthenticator.php', $directory)));
+                }
+            );
+
+        if (Kernel::VERSION_ID < 40100) {
+            $makerTestAuthenticatorLoginFormUserEntity->addExtraDependencies('symfony/form');
+        }
 
-                        $fs = new Filesystem();
-                        $this->assertTrue($fs->exists(sprintf('%s/src/Controller/SecurityController.php', $directory)));
-                        $this->assertTrue($fs->exists(sprintf('%s/templates/security/login.html.twig', $directory)));
-                        $this->assertTrue($fs->exists(sprintf('%s/src/Security/AppCustomAuthenticator.php', $directory)));
-                    }
-                ),
+        yield 'auth_login_form_user_entity' => [
+            $makerTestAuthenticatorLoginFormUserEntity,
         ];
 
         yield 'auth_login_form_user_not_entity' => [
@@ -442,7 +447,8 @@ function (string $output, string $directory) {
             )
                 ->addExtraDependencies('security')
                 ->addExtraDependencies('twig')
-                ->addExtraDependencies('sensio/framework-extra-bundle annot')
+                ->addExtraDependencies('doctrine/annotations')
+                ->addExtraDependencies('symfony/form')
                 ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeAuthenticatorLoginFormUserNotEntity')
                 ->assert(
                     function (string $output) {
@@ -466,6 +472,7 @@ function (string $output) {
                 ->addExtraDependencies('doctrine')
                 ->addExtraDependencies('security')
                 ->addExtraDependencies('twig')
+                ->addExtraDependencies('symfony/form')
                 ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeAuthenticatorLoginFormExistingController')
                 ->configureDatabase()
                 ->updateSchemaAfterCommand()

tests/fixtures/MakeAuthenticatorLoginFormExistingController/config/packages/security.yaml

@@ -1,7 +1,6 @@
 security:
     encoders:
-        App\Security\User:
-            algorithm: bcrypt
+        App\Entity\User: plaintext
 
     # https://symfony.com/doc/current/security.html#where-do-users-come-from-user-providers
     providers:

tests/fixtures/MakeAuthenticatorLoginFormExistingController/src/Controller/DefaultController.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace App\Controller;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\HttpFoundation\Response;
+
+class DefaultController extends AbstractController
+{
+    /**
+     * @Route("/home", name="app_homepage")
+     */
+    public function homepage()
+    {
+        return new Response();
+    }
+}

tests/fixtures/MakeAuthenticatorLoginFormExistingController/tests/SecurityControllerTest.php

@@ -3,6 +3,8 @@
 namespace App\Tests;
 
 use App\Controller\SecurityController;
+use App\Entity\User;
+use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 class SecurityControllerTest extends WebTestCase
@@ -12,17 +14,44 @@ public function testCommand()
         $this->assertTrue(method_exists(SecurityController::class, 'login'));
         $this->assertTrue(method_exists(SecurityController::class, 'logout'));
 
-        $client = self::createClient();
+        $client  = self::createClient();
         $crawler = $client->request('GET', '/login');
 
         $this->assertEquals(200, $client->getResponse()->getStatusCode());
 
+        /** @var EntityManagerInterface $em */
+        $em = self::$kernel->getContainer()
+            ->get('doctrine')
+            ->getManager();
+
+        $user = (new User())->setEmail('[email protected]')
+            ->setPassword('password');
+        $em->persist($user);
+        $em->flush();
+
         $form = $crawler->filter('form')->form();
+        $form->setValues(
+            [
+                'email'    => '[email protected]',
+                'password' => 'foo',
+            ]
+        );
         $client->submit($form);
 
         $this->assertEquals(302, $client->getResponse()->getStatusCode());
         $client->followRedirect();
         $this->assertEquals(200, $client->getResponse()->getStatusCode());
-        $this->assertContains('Username could not be found.', $client->getResponse()->getContent());
+        $this->assertContains('Invalid credentials.', $client->getResponse()->getContent());
+
+        $form->setValues(
+            [
+                'email'    => '[email protected]',
+                'password' => 'password',
+            ]
+        );
+        $client->submit($form);
+
+        $this->assertEquals(302, $client->getResponse()->getStatusCode());
+        $this->assertContains('/home', $client->getResponse()->getContent());
     }
 }

tests/fixtures/MakeAuthenticatorLoginFormUserEntity/config/packages/security.yaml

@@ -1,7 +1,6 @@
 security:
     encoders:
-        App\Entity\User:
-            algorithm: bcrypt
+        App\Entity\User: plaintext
 
     # https://symfony.com/doc/current/security.html#where-do-users-come-from-user-providers
     providers:

tests/fixtures/MakeAuthenticatorLoginFormUserEntity/src/Controller/DefaultController.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace App\Controller;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\HttpFoundation\Response;
+
+class DefaultController extends AbstractController
+{
+    /**
+     * @Route("/home", name="app_homepage")
+     */
+    public function homepage()
+    {
+        return new Response();
+    }
+}

tests/fixtures/MakeAuthenticatorLoginFormUserEntity/tests/SecurityControllerTest.php

@@ -2,23 +2,52 @@
 
 namespace App\Tests;
 
+use App\Entity\User;
+use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 class SecurityControllerTest extends WebTestCase
 {
     public function testCommand()
     {
-        $client = self::createClient();
+        $client  = self::createClient();
         $crawler = $client->request('GET', '/login');
 
         $this->assertEquals(200, $client->getResponse()->getStatusCode());
 
+        /** @var EntityManagerInterface $em */
+        $em = self::$kernel->getContainer()
+            ->get('doctrine')
+            ->getManager();
+
+        $user = (new User())->setEmail('[email protected]')
+            ->setPassword('password');
+        $em->persist($user);
+        $em->flush();
+
         $form = $crawler->filter('form')->form();
+        $form->setValues(
+            [
+                'email'    => '[email protected]',
+                'password' => 'foo',
+            ]
+        );
         $client->submit($form);
 
         $this->assertEquals(302, $client->getResponse()->getStatusCode());
         $client->followRedirect();
         $this->assertEquals(200, $client->getResponse()->getStatusCode());
-        $this->assertContains('Username could not be found.', $client->getResponse()->getContent());
+        $this->assertContains('Invalid credentials.', $client->getResponse()->getContent());
+
+        $form->setValues(
+            [
+                'email'    => '[email protected]',
+                'password' => 'password',
+            ]
+        );
+        $client->submit($form);
+
+        $this->assertEquals(302, $client->getResponse()->getStatusCode());
+        $this->assertContains('/home', $client->getResponse()->getContent());
     }
 }