bug #1324 Fix(Doctrine Repository template)/Avoid potential double call in save method (Mano-Lis)

This PR was squashed before being merged into the 1.0-dev branch.

Discussion
----------

Fix(Doctrine Repository template)/Avoid potential double call in save method

Store the entity manager in a variable rather than calling getEntityManager() twice in case of persist + flush

Commits
-------

a5da934 Fix(Doctrine Repository template)/Avoid potential double call in save method

Author: weaverryan

src/Resources/skeleton/doctrine/Repository.tpl.php

@@ -21,19 +21,21 @@ public function __construct(ManagerRegistry $registry)
 
     public function save(<?= $entity_class_name ?> $entity, bool $flush = false): void
     {
-        $this->getEntityManager()->persist($entity);
+        $entityManager = $this->getEntityManager();
+        $entityManager->persist($entity);
 
         if ($flush) {
-            $this->getEntityManager()->flush();
+            $entityManager->flush();
         }
     }
 
     public function remove(<?= $entity_class_name ?> $entity, bool $flush = false): void
     {
-        $this->getEntityManager()->remove($entity);
+        $entityManager = $this->getEntityManager();
+        $entityManager->remove($entity);
 
         if ($flush) {
-            $this->getEntityManager()->flush();
+            $entityManager->flush();
         }
     }
 <?php if ($include_example_comments): // When adding a new method without existing default comments, the blank line is automatically added.?>

tests/Doctrine/fixtures/expected_xml/src/Repository/UserRepository.php

@@ -23,19 +23,21 @@ public function __construct(ManagerRegistry $registry)
 
     public function save(UserXml $entity, bool $flush = false): void
     {
-        $this->getEntityManager()->persist($entity);
+        $entityManager = $this->getEntityManager();
+        $entityManager->persist($entity);
 
         if ($flush) {
-            $this->getEntityManager()->flush();
+            $entityManager->flush();
         }
     }
 
     public function remove(UserXml $entity, bool $flush = false): void
     {
-        $this->getEntityManager()->remove($entity);
+        $entityManager = $this->getEntityManager();
+        $entityManager->remove($entity);
 
         if ($flush) {
-            $this->getEntityManager()->flush();
+            $entityManager->flush();
         }
     }
 

tests/Doctrine/fixtures/expected_xml/src/Repository/XOtherRepository.php

@@ -23,19 +23,21 @@ public function __construct(ManagerRegistry $registry)
 
     public function save(XOther $entity, bool $flush = false): void
     {
-        $this->getEntityManager()->persist($entity);
+        $entityManager = $this->getEntityManager();
+        $entityManager->persist($entity);
 
         if ($flush) {
-            $this->getEntityManager()->flush();
+            $entityManager->flush();
         }
     }
 
     public function remove(XOther $entity, bool $flush = false): void
     {
-        $this->getEntityManager()->remove($entity);
+        $entityManager = $this->getEntityManager();
+        $entityManager->remove($entity);
 
         if ($flush) {
-            $this->getEntityManager()->flush();
+            $entityManager->flush();
         }
     }