feature #417 [make:functional-test] Use Panther when available. (adrienlucas)

This PR was merged into the 1.0-dev branch.

Discussion
----------

[make:functional-test] Use Panther when available.

Hope this will be useful for others.

Let me know if there are some mistakes to fix !

Commits
-------

3333d6e Generated functional test use Panther when available

Author: weaverryan

src/Maker/MakeFunctionalTest.php

@@ -21,6 +21,7 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\CssSelector\CssSelectorConverter;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestAssertionsTrait;
+use Symfony\Component\Panther\PantherTestCaseTrait;
 
 /**
  * @author Javier Eguiluz <[email protected]>
@@ -55,6 +56,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             'test/Functional.tpl.php',
             [
                 'web_assertions_are_available' => trait_exists(WebTestAssertionsTrait::class),
+                'panther_is_available' => trait_exists(PantherTestCaseTrait::class),
             ]
         );
 
@@ -82,5 +84,11 @@ public function configureDependencies(DependencyBuilder $dependencies)
             true,
             true
         );
+        $dependencies->addClassDependency(
+            PantherTestCaseTrait::class,
+            'panther',
+            false,
+            true
+        );
     }
 }

src/Resources/skeleton/test/Functional.tpl.php

@@ -2,21 +2,25 @@
 
 namespace <?= $namespace; ?>;
 
+<?php if($panther_is_available): ?>
+use Symfony\Component\Panther\PantherTestCase;
+<?php else: ?>
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+<?php endif ?>
 
-class <?= $class_name ?> extends WebTestCase
+class <?= $class_name ?> extends <?= $panther_is_available ? 'PantherTestCase' : 'WebTestCase' ?><?= "\n" ?>
 {
     public function testSomething()
     {
         $client = static::createClient();
         $crawler = $client->request('GET', '/');
 
-<?php if($web_assertions_are_available) { ?>
+<?php if($web_assertions_are_available): ?>
         $this->assertResponseIsSuccessful();
         $this->assertSelectorTextContains('h1', 'Hello World');
-<?php } else { ?>
+<?php else: ?>
         $this->assertSame(200, $client->getResponse()->getStatusCode());
         $this->assertContains('Hello World', $crawler->filter('h1')->text());
-<?php } ?>
+<?php endif ?>
     }
 }

tests/Maker/FunctionalTest.php

@@ -248,6 +248,17 @@ public function getCommandTests()
             ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeFunctional')
         ];
 
+        yield 'functional_with_panther' => [MakerTestDetails::createTest(
+            $this->getMakerInstance(MakeFunctionalTest::class),
+            [
+                // functional test class name
+                'FooBar',
+            ])
+            ->addExtraDependencies('panther')
+            ->setRequiredPhpVersion(70100)
+            ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeFunctional')
+        ];
+
         yield 'subscriber' => [MakerTestDetails::createTest(
             $this->getMakerInstance(MakeSubscriber::class),
             [