Skip to content

Commit b2324e0

Browse files
committed
minor #780 Fixed PHP 7.1.3 tests by using PHPUnit 8.5 (wouterj)
This PR was merged into the 1.0-dev branch. Discussion ---------- Fixed PHP 7.1.3 tests by using PHPUnit 8.5 This fixes the broken PHP 8 tests, as they were using PHPUnit 7.5 (which doesn't support PHP 8). This version is also proposed to the official recipes and will probably be merged shortly: symfony/recipes#868 Commits ------- c739e34 Do not set a PHPUnit version
2 parents ff00742 + c739e34 commit b2324e0

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/Test/MakerTestEnvironment.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,13 +373,19 @@ private function buildFlexSkeleton()
373373
$this->fs->symlink($rootPath.'/vendor/symfony/phpunit-bridge', $this->flexPath.'/vendor/symfony/phpunit-bridge');
374374
}
375375

376-
// temporarily ignoring indirect deprecations - see #237
377376
$replacements = [
377+
// temporarily ignoring indirect deprecations - see #237
378378
[
379379
'filename' => '.env.test',
380380
'find' => 'SYMFONY_DEPRECATIONS_HELPER=999999',
381381
'replace' => 'SYMFONY_DEPRECATIONS_HELPER=max[self]=0',
382382
],
383+
// do not explicitly set the PHPUnit version
384+
[
385+
'filename' => 'phpunit.xml.dist',
386+
'find' => '<server name="SYMFONY_PHPUNIT_VERSION" value="8.5" />',
387+
'replace' => '',
388+
],
383389
];
384390
$this->processReplacements($replacements, $this->flexPath);
385391
// end of temp code

0 commit comments

Comments
 (0)