feature #381 [make:*-test] Use the new WebTestAssertionsTrait methods in the generated functional tests (adrienlucas)

This PR was merged into the 1.0-dev branch.

Discussion
----------

[make:*-test] Use the new WebTestAssertionsTrait methods in the generated functional tests

Hi, this PR is to fix the way of calling the assertions static methods of PHPunit in the generated unit and functional tests.

[First commit](8f4af14) : As pointed out in [this article](https://arkadiuszkondas.com/the-right-way-to-call-assertion-in-phpunit/), we should not be calling the assertions using `$this->assert*` but instead with `static::assert*`.

[Second commit](cfb0715) : To go further, we can use [the new assertion API](symfony/symfony#30813) provided by the `WebTestCase`.

I don't kown if this could be considered a BC break... but i hope not.

Commits
-------

5982f3c Use the new api provided by the WebTestAssertionsTrait

Author: weaverryan

src/Maker/MakeFunctionalTest.php

@@ -20,6 +20,7 @@
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\CssSelector\CssSelectorConverter;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestAssertionsTrait;
 
 /**
  * @author Javier Eguiluz <[email protected]>
@@ -52,7 +53,9 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
         $generator->generateClass(
             $testClassNameDetails->getFullName(),
             'test/Functional.tpl.php',
-            []
+            [
+                'web_assertions_are_available' => class_exists(WebTestAssertionsTrait::class),
+            ]
         );
 
         $generator->writeChanges();

src/Resources/skeleton/test/Functional.tpl.php

@@ -11,7 +11,12 @@ public function testSomething()
         $client = static::createClient();
         $crawler = $client->request('GET', '/');
 
+<?php if($web_assertions_are_available) { ?>
+        $this->assertResponseIsSuccessful();
+        $this->assertSelectorTextContains('h1', 'Hello World');
+<?php } else { ?>
         $this->assertSame(200, $client->getResponse()->getStatusCode());
         $this->assertContains('Hello World', $crawler->filter('h1')->text());
+<?php } ?>
     }
 }