drop PHP 7.x support (#1122)

Author: jrushlow

.github/workflows/ci.yaml

@@ -22,7 +22,7 @@ jobs:
             fail-fast: false
             matrix:
                 php-version:
-                    - '7.4'
+                    - '8.0'
 
         steps:
             -
@@ -99,11 +99,11 @@ jobs:
                 allow-dev-deps-in-apps: ['0']
                 include:
                     # testing lowest PHP version with LTS
-                    - php-version: '7.2.5'
+                    - php-version: '8.0.0'
                       symfony-version: '5.4.*'
                       dependency-versions: 'lowest'
                     # testing lowest php version with highest 5.x stable
-                    - php-version: '7.2.5'
+                    - php-version: '8.0.0'
                       symfony-version: '5.4.*'
                       dependency-versions: 'highest'
                     # testing bleeding edge PHP with highest 5.x stable

appveyor.yml

@@ -27,7 +27,7 @@ environment:
     TEST_DATABASE_DSN: mysql://root:[email protected]:3306/test_maker
     matrix:
       - dependencies: highest
-        php_ver_target: 7.2.5
+        php_ver_target: 8.0.19
 
 install:
     - ps: Set-Service wuauserv -StartupType Manual

composer.json

@@ -13,7 +13,7 @@
     ],
     "minimum-stability": "dev",
     "require": {
-        "php": ">=7.2.5",
+        "php": ">=8.0",
         "doctrine/inflector": "^2.0",
         "nikic/php-parser": "^4.11",
         "symfony/config": "^5.4.7|^6.0",

src/Command/MakerCommand.php

@@ -32,20 +32,13 @@
  */
 final class MakerCommand extends Command
 {
-    private $maker;
-    private $fileManager;
-    private $inputConfig;
-    /** @var ConsoleStyle */
-    private $io;
-    private $checkDependencies = true;
-    private $generator;
-
-    public function __construct(MakerInterface $maker, FileManager $fileManager, Generator $generator)
+    private InputConfiguration $inputConfig;
+    private ConsoleStyle $io;
+    private bool $checkDependencies = true;
+
+    public function __construct(private MakerInterface $maker, private FileManager $fileManager, private Generator $generator)
     {
-        $this->maker = $maker;
-        $this->fileManager = $fileManager;
         $this->inputConfig = new InputConfiguration();
-        $this->generator = $generator;
 
         parent::__construct();
     }

src/Doctrine/DoctrineHelper.php

@@ -145,7 +145,7 @@ public function doesClassUsesAttributes(string $className): bool
 
     public function isDoctrineSupportingAttributes(): bool
     {
-        return $this->isDoctrineInstalled() && $this->attributeMappingSupport && $this->phpCompatUtil->canUseAttributes();
+        return $this->isDoctrineInstalled() && $this->attributeMappingSupport;
     }
 
     public function getEntitiesForAutocomplete(): array

src/Generator.php

@@ -170,9 +170,6 @@ private function addOperation(string $targetPath, string $templateName, array $v
         }
 
         $variables['relative_path'] = $this->fileManager->relativizePath($targetPath);
-        $variables['use_attributes'] = $this->phpCompatUtil->canUseAttributes();
-        $variables['use_typed_properties'] = $this->phpCompatUtil->canUseTypedProperties();
-        $variables['use_union_types'] = $this->phpCompatUtil->canUseUnionTypes();
 
         $templatePath = $templateName;
         if (!file_exists($templatePath)) {

src/Maker/MakeAuthenticator.php

@@ -65,19 +65,13 @@ final class MakeAuthenticator extends AbstractMaker
     private const AUTH_TYPE_EMPTY_AUTHENTICATOR = 'empty-authenticator';
     private const AUTH_TYPE_FORM_LOGIN = 'form-login';
 
-    private $fileManager;
-    private $configUpdater;
-    private $generator;
-    private $doctrineHelper;
-    private $securityControllerBuilder;
-
-    public function __construct(FileManager $fileManager, SecurityConfigUpdater $configUpdater, Generator $generator, DoctrineHelper $doctrineHelper, SecurityControllerBuilder $securityControllerBuilder)
-    {
-        $this->fileManager = $fileManager;
-        $this->configUpdater = $configUpdater;
-        $this->generator = $generator;
-        $this->doctrineHelper = $doctrineHelper;
-        $this->securityControllerBuilder = $securityControllerBuilder;
+    public function __construct(
+        private FileManager $fileManager,
+        private SecurityConfigUpdater $configUpdater,
+        private Generator $generator,
+        private DoctrineHelper $doctrineHelper,
+        private SecurityControllerBuilder $securityControllerBuilder
+    ) {
     }
 
     public static function getCommandName(): string

src/Maker/MakeCommand.php

@@ -33,11 +33,8 @@
  */
 final class MakeCommand extends AbstractMaker
 {
-    private $phpCompatUtil;
-
-    public function __construct(PhpCompatUtil $phpCompatUtil)
+    public function __construct(private PhpCompatUtil $phpCompatUtil)
     {
-        $this->phpCompatUtil = $phpCompatUtil;
     }
 
     public static function getCommandName(): string
@@ -77,12 +74,9 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             InputOption::class,
             OutputInterface::class,
             SymfonyStyle::class,
+            AsCommand::class,
         ]);
 
-        if ($this->phpCompatUtil->canUseAttributes()) {
-            $useStatements->addUseStatement(AsCommand::class);
-        }
-
         $generator->generateClass(
             $commandClassNameDetails->getFullName(),
             'command/Command.tpl.php',

src/Maker/MakeController.php

@@ -36,7 +36,7 @@
  */
 final class MakeController extends AbstractMaker
 {
-    private $phpCompatUtil;
+    private PhpCompatUtil $phpCompatUtil;
 
     public function __construct(PhpCompatUtil $phpCompatUtil = null)
     {
@@ -116,7 +116,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
     public function configureDependencies(DependencyBuilder $dependencies): void
     {
         // @legacy - Remove method when support for Symfony 5.4 is dropped
-        if (null !== $this->phpCompatUtil && 60000 <= Kernel::VERSION_ID && $this->phpCompatUtil->canUseAttributes()) {
+        if (null !== $this->phpCompatUtil && 60000 <= Kernel::VERSION_ID) {
             return;
         }
 

src/Maker/MakeCrud.php

@@ -12,6 +12,7 @@
 namespace Symfony\Bundle\MakerBundle\Maker;
 
 use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
+use Doctrine\Inflector\Inflector;
 use Doctrine\Inflector\InflectorFactory;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\EntityRepository;
@@ -45,16 +46,12 @@
  */
 final class MakeCrud extends AbstractMaker
 {
-    private $doctrineHelper;
-    private $formTypeRenderer;
-    private $inflector;
-    private $controllerClassName;
-    private $generateTests = false;
+    private Inflector $inflector;
+    private string $controllerClassName;
+    private bool $generateTests = false;
 
-    public function __construct(DoctrineHelper $doctrineHelper, FormTypeRenderer $formTypeRenderer)
+    public function __construct(private DoctrineHelper $doctrineHelper, private FormTypeRenderer $formTypeRenderer)
     {
-        $this->doctrineHelper = $doctrineHelper;
-        $this->formTypeRenderer = $formTypeRenderer;
         $this->inflector = InflectorFactory::create()->build();
     }