Leverage symfony-tools/fabbot

Author: nicolas-grekas

.github/workflows/fabbot.yml

@@ -0,0 +1,14 @@
+name: CS
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  call-fabbot:
+    name: Fabbot
+    uses: symfony-tools/fabbot/.github/workflows/fabbot.yml@main
+    with:
+      package: MakerBundle

src/Maker/MakeMigration.php

@@ -114,7 +114,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
         try {
             $returnCode = $generateMigrationCommand->run($generateMigrationCommandInput, $commandOutput);
 
-            // non-zero code would ideally mean the internal command has already printed an errror
+            // non-zero code would ideally mean the internal command has already printed an error
             // this happens if you "decline" generating a migration when you already
             // have some available
             if (0 !== $returnCode) {

tests/Command/MakerCommandTest.php

@@ -23,7 +23,7 @@
 
 class MakerCommandTest extends TestCase
 {
-    public function testExceptionOnMissingDependencies(): void
+    public function testExceptionOnMissingDependencies()
     {
         $this->expectException(RuntimeCommandException::class);
         if (method_exists($this, 'expectExceptionMessageMatches')) {
@@ -47,7 +47,7 @@ public function testExceptionOnMissingDependencies(): void
         $tester->execute([]);
     }
 
-    public function testExceptionOnUnknownRootNamespace(): void
+    public function testExceptionOnUnknownRootNamespace()
     {
         $maker = $this->createMock(MakerInterface::class);
 

tests/Docker/DatabaseServicesTest.php

@@ -20,7 +20,7 @@
  */
 final class DatabaseServicesTest extends TestCase
 {
-    public function testExceptionThrownWithInvalidDatabaseProvided(): void
+    public function testExceptionThrownWithInvalidDatabaseProvided()
     {
         $this->expectException(RuntimeCommandException::class);
         $this->expectExceptionMessage('foo is not a valid / supported docker database type.');
@@ -38,7 +38,7 @@ public function mixedNameDataProvider(): \Generator
     /**
      * @dataProvider mixedNameDataProvider
      */
-    public function testSkeletonReturnArrayForDesiredDatabase(string $databaseName): void
+    public function testSkeletonReturnArrayForDesiredDatabase(string $databaseName)
     {
         $result = DockerDatabaseServices::getDatabaseSkeleton($databaseName, 'latest');
 
@@ -49,7 +49,7 @@ public function testSkeletonReturnArrayForDesiredDatabase(string $databaseName):
     /**
      * @dataProvider mixedNameDataProvider
      */
-    public function testGetDefaultPorts(string $databaseName): void
+    public function testGetDefaultPorts(string $databaseName)
     {
         $result = DockerDatabaseServices::getDefaultPorts($databaseName);
 
@@ -59,7 +59,7 @@ public function testGetDefaultPorts(string $databaseName): void
     /**
      * @dataProvider mixedNameDataProvider
      */
-    public function testSuggestedVersion(string $databaseName): void
+    public function testSuggestedVersion(string $databaseName)
     {
         $result = DockerDatabaseServices::getSuggestedServiceVersion($databaseName);
 

tests/Doctrine/EntityRegeneratorTest.php

@@ -37,7 +37,7 @@ class EntityRegeneratorTest extends TestCase
     /**
      * @dataProvider getRegenerateEntitiesTests
      */
-    public function testRegenerateEntities(string $expectedDirName, bool $overwrite): void
+    public function testRegenerateEntities(string $expectedDirName, bool $overwrite)
     {
         $kernel = new TestEntityRegeneratorKernel('dev', true);
         $this->doTestRegeneration(

tests/FileManagerTest.php

@@ -188,7 +188,7 @@ public function getPathForTemplateTests()
         ];
     }
 
-    public function testWithMakerFileLinkFormatter(): void
+    public function testWithMakerFileLinkFormatter()
     {
         if (getenv('MAKER_DISABLE_FILE_LINKS')) {
             $this->markTestSkipped();

tests/GeneratorTest.php

@@ -20,7 +20,7 @@ class GeneratorTest extends TestCase
     /**
      * @dataProvider getClassNameDetailsTests
      */
-    public function testCreateClassNameDetails(string $name, string $prefix, string $suffix, string $expectedFullClassName, string $expectedRelativeClassName): void
+    public function testCreateClassNameDetails(string $name, string $prefix, string $suffix, string $expectedFullClassName, string $expectedRelativeClassName)
     {
         $fileManager = $this->createMock(FileManager::class);
         $fileManager->expects($this->any())

tests/Maker/FunctionalTest.php

@@ -24,7 +24,7 @@ class FunctionalTest extends TestCase
      * Smoke test to make sure the DI autowiring works and all makers
      * are registered and have the correct arguments.
      */
-    public function testWiring(): void
+    public function testWiring()
     {
         $kernel = new MakerTestKernel('dev', true);
 

tests/RegexTest.php

@@ -26,7 +26,7 @@
 class RegexTest extends TestCase
 {
     /** @dataProvider generatedFilesRegexDataProvider */
-    public function testMakerTestEnvironmentGeneratedFilesRegex(string $subjectData, array $expectedResult): void
+    public function testMakerTestEnvironmentGeneratedFilesRegex(string $subjectData, array $expectedResult)
     {
         $result = [];
 
@@ -69,7 +69,7 @@ private function generatedFilesRegexDataProvider(): \Generator
     }
 
     /** @dataProvider webhookNameRegexDataProvider */
-    public function testWebhookNameRegex(string $subjectData, bool $expectedResult): void
+    public function testWebhookNameRegex(string $subjectData, bool $expectedResult)
     {
         $result = preg_match(MakeWebhook::WEBHOOK_NAME_PATTERN, $subjectData);
 

tests/Security/InteractiveSecurityHelperTest.php

@@ -209,7 +209,7 @@ public function guessEmailFieldTest()
     }
 
     /** @dataProvider authenticatorClassProvider */
-    public function testGetAuthenticatorsFromConfig(array $firewalls, array $expectedResults): void
+    public function testGetAuthenticatorsFromConfig(array $firewalls, array $expectedResults)
     {
         $helper = new InteractiveSecurityHelper();
         $result = $helper->getAuthenticatorsFromConfig($firewalls);