Skip to content

Commit eb2bcd0

Browse files
jrushlowweaverryan
authored andcommitted
fixed minor issues failing test on master
1 parent ccb68bf commit eb2bcd0

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

src/Maker/MakeForgottenPassword.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,23 @@
1515
use Symfony\Bundle\MakerBundle\DependencyBuilder;
1616
use Symfony\Bundle\MakerBundle\Doctrine\ORMDependencyBuilder;
1717
use Symfony\Bundle\MakerBundle\Exception\RuntimeCommandException;
18+
use Symfony\Bundle\MakerBundle\FileManager;
1819
use Symfony\Bundle\MakerBundle\Generator;
1920
use Symfony\Bundle\MakerBundle\InputConfiguration;
21+
use Symfony\Bundle\MakerBundle\Renderer\FormTypeRenderer;
2022
use Symfony\Bundle\MakerBundle\Security\InteractiveSecurityHelper;
2123
use Symfony\Bundle\MakerBundle\Util\YamlSourceManipulator;
2224
use Symfony\Bundle\SecurityBundle\SecurityBundle;
25+
use Symfony\Bundle\SwiftmailerBundle\SwiftmailerBundle;
2326
use Symfony\Bundle\TwigBundle\TwigBundle;
2427
use Symfony\Component\Console\Command\Command;
2528
use Symfony\Component\Console\Input\InputInterface;
2629
use Symfony\Component\Form\AbstractType;
27-
use Symfony\Component\Form\Extension\Core\Type\PasswordType;
2830
use Symfony\Component\Form\Extension\Core\Type\EmailType;
31+
use Symfony\Component\Form\Extension\Core\Type\PasswordType;
2932
use Symfony\Component\Form\Extension\Core\Type\RepeatedType;
3033
use Symfony\Component\Routing\RouterInterface;
31-
use Symfony\Bundle\MakerBundle\FileManager;
32-
use Symfony\Bundle\MakerBundle\Renderer\FormTypeRenderer;
3334
use Symfony\Component\Validator\Validation;
34-
use Symfony\Bundle\SwiftmailerBundle\SwiftmailerBundle;
3535

3636
/**
3737
* @author Romaric Drigon <[email protected]>

src/Renderer/FormTypeRenderer.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,17 @@ public function render(ClassNameDetails $formClassDetails, array $formFields, Cl
4242
$fields[$name] = $fieldTypeOptions;
4343
}
4444

45+
$mergedTypeUseStatements = array_merge($fieldTypeUseStatements, $extraUseClasses);
46+
sort($mergedTypeUseStatements);
47+
4548
$this->generator->generateClass(
4649
$formClassDetails->getFullName(),
4750
'form/Type.tpl.php',
4851
[
4952
'bounded_full_class_name' => $boundClassDetails ? $boundClassDetails->getFullName() : null,
5053
'bounded_class_name' => $boundClassDetails ? $boundClassDetails->getShortName() : null,
5154
'form_fields' => $fields,
52-
'field_type_use_statements' => array_merge($fieldTypeUseStatements, $extraUseClasses),
55+
'field_type_use_statements' => $mergedTypeUseStatements,
5356
'constraint_use_statements' => $constraintClasses,
5457
]
5558
);

tests/Maker/MakeForgottenPasswordTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public function getTestDetails()
2121
->setFixtureFilesPath(__DIR__.'/../fixtures/MakeForgottenPassword')
2222
->configureDatabase()
2323
->updateSchemaAfterCommand()
24+
->addExtraDependencies('symfony/swiftmailer-bundle')
2425
];
2526
}
2627
}

0 commit comments

Comments
 (0)