feature #52 Deprecate enable_profiler (mtarld)

This PR was merged into the 0.3.x-dev branch.

Discussion
----------

Deprecate enable_profiler

Commits
-------

583ab25 Deprecate enable_profiler

Author: chalasr

CHANGELOG.md

@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+0.3.3
+-----
+
+* Deprecate `enable_profiler` configuration
+
 0.3.2
 -----
 

src/DependencyInjection/Configuration.php

@@ -88,7 +88,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                     ->end()
                     ->scalarNode('default_hub')->end()
                     ->integerNode('default_cookie_lifetime')->defaultNull()->info('Default lifetime of the cookie containing the JWT, in seconds. Defaults to the value of "framework.session.cookie_lifetime".')->end()
-                    ->booleanNode('enable_profiler')->info('Enable Symfony Web Profiler integration.')->defaultFalse()->end()
+                    ->booleanNode('enable_profiler')->info('Enable Symfony Web Profiler integration.')->setDeprecated('symfony/mercure-bundle', '0.3')->end()
                 ->end()
             ->end()
         ;

src/DependencyInjection/MercureExtension.php

@@ -71,7 +71,7 @@ public function load(array $configs, ContainerBuilder $container)
         $hubs = [];
         $defaultHubUrl = null;
         $defaultHubName = null;
-        $enableProfiler = $config['enable_profiler'] && class_exists(Stopwatch::class);
+        $enableProfiler = ($config['enable_profiler'] ?? $container->getParameter('kernel.debug')) && class_exists(Stopwatch::class);
         foreach ($config['hubs'] as $name => $hub) {
             $tokenFactory = null;
             if (isset($hub['jwt'])) {

tests/DependencyInjection/MercureExtensionTest.php

@@ -16,6 +16,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Bundle\MercureBundle\DependencyInjection\MercureExtension;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
 use Symfony\Component\Mercure\HubRegistry;
 
 /**
@@ -36,7 +37,7 @@ public function testExtensionMinimum(): void
             ],
         ];
 
-        $container = new ContainerBuilder();
+        $container = new ContainerBuilder(new ParameterBag(['kernel.debug' => false]));
         (new MercureExtension())->load($config, $container);
 
         $this->assertTrue($container->hasDefinition('mercure.hub.default')); // Hub instance
@@ -83,7 +84,7 @@ public function testExtension(): void
             ],
         ];
 
-        $container = new ContainerBuilder();
+        $container = new ContainerBuilder(new ParameterBag(['kernel.debug' => false]));
         (new MercureExtension())->load($config, $container);
 
         $this->assertTrue($container->hasDefinition('mercure.hub.managed')); // Hub instance
@@ -154,7 +155,7 @@ public function testExtensionLegacy()
             ],
         ];
 
-        $container = new ContainerBuilder();
+        $container = new ContainerBuilder(new ParameterBag(['kernel.debug' => false]));
         (new MercureExtension())->load($config, $container);
 
         $this->assertTrue($container->hasDefinition('mercure.hub.default.jwt_provider'));