Skip to content

Commit 3047aa0

Browse files
minor #28441 [Messenger] simple refactoring to have a more readable code (ronfroy)
This PR was squashed before being merged into the 4.2-dev branch (closes #28441). Discussion ---------- [Messenger] simple refactoring to have a more readable code | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT <!-- A simple refactoring to have a more readable code --> Commits ------- 5f61a27db5 [Messenger] simple refactoring to have a more readable code
2 parents 616aaca + 609c79a commit 3047aa0

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

Handler/Locator/AbstractHandlerLocator.php

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,8 @@ abstract class AbstractHandlerLocator implements HandlerLocatorInterface
2121
{
2222
public function resolve($message): callable
2323
{
24-
$messageClass = \get_class($message);
24+
$class = \get_class($message);
2525

26-
if (null === $handler = $this->resolveFromClass($messageClass)) {
27-
throw new NoHandlerForMessageException(sprintf('No handler for message "%s".', $messageClass));
28-
}
29-
30-
return $handler;
31-
}
32-
33-
private function resolveFromClass(string $class): ?callable
34-
{
3526
if ($handler = $this->getHandler($class)) {
3627
return $handler;
3728
}
@@ -48,7 +39,7 @@ private function resolveFromClass(string $class): ?callable
4839
}
4940
}
5041

51-
return null;
42+
throw new NoHandlerForMessageException(sprintf('No handler for message "%s".', $class));
5243
}
5344

5445
abstract protected function getHandler(string $class);

0 commit comments

Comments
 (0)