[Messenger] fix wrong use of generator returns

And some other minor cleanups

Author: Tobion

Stamp/SentToFailureTransportStamp.php

@@ -32,7 +32,7 @@ public function __construct(string $exceptionMessage, string $originalReceiverNa
         $this->exceptionMessage = $exceptionMessage;
         $this->originalReceiverName = $originalReceiverName;
         $this->flattenException = $flattenException;
-        $this->sentAt = new \DateTime();
+        $this->sentAt = new \DateTimeImmutable();
     }
 
     public function getExceptionMessage(): string
@@ -50,7 +50,7 @@ public function getFlattenException(): ?FlattenException
         return $this->flattenException;
     }
 
-    public function getSentAt(): \DateTime
+    public function getSentAt(): \DateTimeInterface
     {
         return $this->sentAt;
     }

Tests/Stamp/SentToFailureTransportStampTest.php

@@ -28,6 +28,6 @@ public function testGetters()
         $this->assertSame('exception message', $stamp->getExceptionMessage());
         $this->assertSame('original_receiver', $stamp->getOriginalReceiverName());
         $this->assertSame($flattenException, $stamp->getFlattenException());
-        $this->assertInstanceOf(\DateTime::class, $stamp->getSentAt());
+        $this->assertInstanceOf(\DateTimeInterface::class, $stamp->getSentAt());
     }
 }

Tests/Transport/Doctrine/DoctrineReceiverTest.php

@@ -36,7 +36,7 @@ public function testItReturnsTheDecodedMessageToTheHandler()
         $connection->method('get')->willReturn($doctrineEnvelope);
 
         $receiver = new DoctrineReceiver($connection, $serializer);
-        $actualEnvelopes = iterator_to_array($receiver->get());
+        $actualEnvelopes = $receiver->get();
         $this->assertCount(1, $actualEnvelopes);
         /** @var Envelope $actualEnvelope */
         $actualEnvelope = $actualEnvelopes[0];
@@ -67,7 +67,7 @@ public function testItRejectTheMessageIfThereIsAMessageDecodingFailedException()
         $connection->expects($this->once())->method('reject');
 
         $receiver = new DoctrineReceiver($connection, $serializer);
-        iterator_to_array($receiver->get());
+        $receiver->get();
     }
 
     public function testAll()

Tests/Transport/Doctrine/DoctrineTransportTest.php

@@ -46,7 +46,7 @@ public function testReceivesMessages()
         $serializer->method('decode')->with(['body' => 'body', 'headers' => ['my' => 'header']])->willReturn(new Envelope($decodedMessage));
         $connection->method('get')->willReturn($doctrineEnvelope);
 
-        $envelopes = iterator_to_array($transport->get());
+        $envelopes = $transport->get();
         $this->assertSame($decodedMessage, $envelopes[0]->getMessage());
     }
 

Tests/Transport/Receiver/SingleMessageReceiverTest.php

@@ -13,12 +13,8 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Messenger\Envelope;
-use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
-use Symfony\Component\Messenger\Tests\Fixtures\SecondMessage;
 use Symfony\Component\Messenger\Transport\Receiver\ReceiverInterface;
 use Symfony\Component\Messenger\Transport\Receiver\SingleMessageReceiver;
-use Symfony\Component\Messenger\Transport\Sender\SenderInterface;
-use Symfony\Component\Messenger\Transport\Sender\SendersLocator;
 
 class SingleMessageReceiverTest extends TestCase
 {
@@ -28,11 +24,11 @@ public function testItReceivesOnlyOneMessage()
         $envelope = new Envelope(new \stdClass());
 
         $receiver = new SingleMessageReceiver($innerReceiver, $envelope);
-        $received = \iterator_to_array($receiver->get());
+        $received = $receiver->get();
         $this->assertCount(1, $received);
         $this->assertSame($received[0], $envelope);
 
-        $this->assertEmpty(\iterator_to_array($receiver->get()));
+        $this->assertEmpty($receiver->get());
     }
 
     public function testCallsAreForwarded()

Tests/Transport/RedisExt/RedisReceiverTest.php

@@ -33,7 +33,7 @@ public function testItReturnsTheDecodedMessageToTheHandler()
         $connection->method('get')->willReturn($redisEnvelop);
 
         $receiver = new RedisReceiver($connection, $serializer);
-        $actualEnvelopes = iterator_to_array($receiver->get());
+        $actualEnvelopes = $receiver->get();
         $this->assertCount(1, $actualEnvelopes);
         $this->assertEquals(new DummyMessage('Hi'), $actualEnvelopes[0]->getMessage());
     }
@@ -51,7 +51,7 @@ public function testItRejectTheMessageIfThereIsAMessageDecodingFailedException()
         $connection->expects($this->once())->method('reject');
 
         $receiver = new RedisReceiver($connection, $serializer);
-        iterator_to_array($receiver->get());
+        $receiver->get();
     }
 
     private function createRedisEnvelope()

Tests/Transport/RedisExt/RedisTransportTest.php

@@ -46,7 +46,7 @@ public function testReceivesMessages()
         $serializer->method('decode')->with(['body' => 'body', 'headers' => ['my' => 'header']])->willReturn(new Envelope($decodedMessage));
         $connection->method('get')->willReturn($redisEnvelope);
 
-        $envelopes = iterator_to_array($transport->get());
+        $envelopes = $transport->get();
         $this->assertSame($decodedMessage, $envelopes[0]->getMessage());
     }
 

Transport/AmqpExt/AmqpReceiver.php

@@ -57,7 +57,7 @@ private function getEnvelope(string $queueName): iterable
         }
 
         if (null === $amqpEnvelope) {
-            return [];
+            return;
         }
 
         try {

Transport/AmqpExt/AmqpTransport.php

@@ -84,12 +84,12 @@ public function getMessageCount(): int
         return ($this->receiver ?? $this->getReceiver())->getMessageCount();
     }
 
-    private function getReceiver()
+    private function getReceiver(): AmqpReceiver
     {
         return $this->receiver = new AmqpReceiver($this->connection, $this->serializer);
     }
 
-    private function getSender()
+    private function getSender(): AmqpSender
     {
         return $this->sender = new AmqpSender($this->connection, $this->serializer);
     }

Transport/Doctrine/DoctrineReceiver.php

@@ -54,7 +54,7 @@ public function get(): iterable
             return [];
         }
 
-        yield $this->createEnvelopeFromData($doctrineEnvelope);
+        return [$this->createEnvelopeFromData($doctrineEnvelope)];
     }
 
     /**