Skip to content

Commit ba8b68e

Browse files
committed
bug #27220 [Messenger] Fix new AMQP Transport test with Envelope & fix contract (ogizanagi)
This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Fix new AMQP Transport test with Envelope & fix contract | Q | A | ------------- | --- | Branch? | 4.1 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/377246434#L3685-L3686, https://ci.appveyor.com/project/fabpot/symfony/build/1.0.36261#L297 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Commits ------- 7223bd75f9 [Messenger] Fix new AMQP Transport test with Envelope
2 parents f0670f6 + a8f5516 commit ba8b68e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Tests/Transport/AmqpExt/AmqpTransportTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace Symfony\Component\Messenger\Tests\Transport\AmqpExt;
1313

1414
use PHPUnit\Framework\TestCase;
15+
use Symfony\Component\Messenger\Envelope;
1516
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
1617
use Symfony\Component\Messenger\Transport\AmqpExt\AmqpTransport;
1718
use Symfony\Component\Messenger\Transport\AmqpExt\Connection;
@@ -45,11 +46,11 @@ public function testReceivesMessages()
4546
$amqpEnvelope->method('getBody')->willReturn('body');
4647
$amqpEnvelope->method('getHeaders')->willReturn(array('my' => 'header'));
4748

48-
$decoder->method('decode')->with(array('body' => 'body', 'headers' => array('my' => 'header')))->willReturn($decodedMessage);
49+
$decoder->method('decode')->with(array('body' => 'body', 'headers' => array('my' => 'header')))->willReturn(Envelope::wrap($decodedMessage));
4950
$connection->method('get')->willReturn($amqpEnvelope);
5051

51-
$transport->receive(function ($message) use ($transport, $decodedMessage) {
52-
$this->assertSame($decodedMessage, $message);
52+
$transport->receive(function (Envelope $envelope) use ($transport, $decodedMessage) {
53+
$this->assertSame($decodedMessage, $envelope->getMessage());
5354

5455
$transport->stop();
5556
});

Transport/AmqpExt/AmqpTransport.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Messenger\Transport\AmqpExt;
1313

14+
use Symfony\Component\Messenger\Envelope;
1415
use Symfony\Component\Messenger\Transport\Serialization\DecoderInterface;
1516
use Symfony\Component\Messenger\Transport\Serialization\EncoderInterface;
1617
use Symfony\Component\Messenger\Transport\TransportInterface;
@@ -52,9 +53,9 @@ public function stop(): void
5253
/**
5354
* {@inheritdoc}
5455
*/
55-
public function send($message): void
56+
public function send(Envelope $envelope): void
5657
{
57-
($this->sender ?? $this->getSender())->send($message);
58+
($this->sender ?? $this->getSender())->send($envelope);
5859
}
5960

6061
private function getReceiver()

0 commit comments

Comments
 (0)