merge handler and listener

Author: Tobion

DependencyInjection/MonologExtension.php

@@ -28,7 +28,6 @@
 class MonologExtension extends Extension
 {
     private $nestedHandlers = array();
-    private $consoleHandlers = array();
 
     /**
      * Loads the Monolog configuration.
@@ -55,12 +54,6 @@ public function load(array $configs, ContainerBuilder $container)
                 );
             }
 
-            if ($this->consoleHandlers) {
-                $consoleListener = $container->getDefinition('monolog.listener.console');
-                $consoleListener->replaceArgument(0, $this->consoleHandlers);
-                $consoleListener->setAbstract(false);
-            }
-
             ksort($handlers);
             $sortedHandlers = array();
             foreach ($handlers as $priorityHandlers) {
@@ -134,7 +127,7 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler
             $definition->setArguments(array(
                 $handler['bubble'],
             ));
-            $this->consoleHandlers[] = new Reference($handlerId);
+            $definition->addTag('kernel.event_subscriber');
             break;
 
         case 'firephp':

EventListener/LogToConsoleListener.php

@@ -14,17 +14,22 @@
 use Monolog\Handler\AbstractProcessingHandler;
 use Monolog\Logger;
 use Symfony\Bundle\MonologBundle\Formatter\ConsoleFormatter;
+use Symfony\Component\Console\ConsoleEvents;
+use Symfony\Component\Console\Event\ConsoleCommandEvent;
+use Symfony\Component\Console\Event\ConsoleTerminateEvent;
 use Symfony\Component\Console\Output\ConsoleOutputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 
 /**
  * Writes to the console output depending on its verbosity setting.
  *
- * It is disabled by default and gets activated when setOutput is called.
+ * It is disabled by default and gets activated as soon as a command is executed.
+ * Instead of listening to the console events, setOutput can also be called manually.
  *
  * @author Tobias Schultze <http://tobion.de>
  */
-class ConsoleHandler extends AbstractProcessingHandler
+class ConsoleHandler extends AbstractProcessingHandler implements EventSubscriberInterface
 {
     /**
      * @var OutputInterface|null
@@ -106,6 +111,38 @@ public function close()
         parent::close();
     }
 
+    /**
+     * Before a command is executed, the handler gets activated and the console output
+     * is set in order to know where to write the logs.
+     *
+     * @param ConsoleCommandEvent $event
+     */
+    public function onCommand(ConsoleCommandEvent $event)
+    {
+        $this->setOutput($event->getOutput());
+    }
+
+    /**
+     * After a command has been executed, it disables the output.
+     *
+     * @param ConsoleTerminateEvent $event
+     */
+    public function onTerminate(ConsoleTerminateEvent $event)
+    {
+        $this->close();
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public static function getSubscribedEvents()
+    {
+        return array(
+            ConsoleEvents::COMMAND => 'onCommand',
+            ConsoleEvents::TERMINATE => 'onTerminate'
+        );
+    }
+
     /**
      * {@inheritdoc}
      */

Handler/ConsoleHandler.php

@@ -40,11 +40,5 @@
         <service id="monolog.logger_prototype" class="%monolog.logger.class%" abstract="true">
             <argument /><!-- Channel -->
         </service>
-
-        <!-- The MonologExtension removes the abstract flag when handlers of type "console" are used and inserts them -->
-        <service id="monolog.listener.console" class="%monolog.listener.console.class%" abstract="true">
-            <tag name="kernel.event_subscriber" />
-            <argument type="collection" /><!-- Array of ConsoleHandler instances -->
-        </service>
     </services>
 </container>