bug #188 Drop DebugHandlerPass (nicolas-grekas)

This PR was merged into the 3.x-dev branch.

Discussion
----------

Drop DebugHandlerPass

Bug fix for 3.0 because this deprecated code should have been removed.
Fixes #187

Commits
-------

b46da89 Drop DebugHandlerPass

Author: fabpot

DependencyInjection/Compiler/DebugHandlerPass.php

@@ -231,10 +231,6 @@
  *   - [level]: level name or int value, defaults to DEBUG
  *   - [bubble]: bool, defaults to true
  *
- * - debug:
- *   - [level]: level name or int value, defaults to DEBUG
- *   - [bubble]: bool, defaults to true
- *
  * - loggly:
  *   - token: loggly api token
  *   - [level]: level name or int value, defaults to DEBUG
@@ -740,10 +736,6 @@ public function getConfigTreeBuilder()
                             ->thenInvalid('The source has to be specified to use a FlowdockHandler')
                         ->end()
                     ->end()
-                    ->validate()
-                        ->ifTrue(function ($v) { return isset($v['debug']); })
-                        ->thenInvalid('The "debug" name cannot be used as it is reserved for the handler of the profiler')
-                    ->end()
                     ->example(array(
                         'syslog' => array(
                             'type' => 'stream',

DependencyInjection/Configuration.php

@@ -657,7 +657,6 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler
         case 'browser_console':
         case 'test':
         case 'null':
-        case 'debug':
             $definition->setArguments(array(
                 $handler['level'],
                 $handler['bubble'],
@@ -713,7 +712,6 @@ private function getHandlerClassByType($handlerType)
             'browser_console' => 'Monolog\Handler\BrowserConsoleHandler',
             'firephp' => 'Symfony\Bridge\Monolog\Handler\FirePHPHandler',
             'chromephp' => 'Symfony\Bridge\Monolog\Handler\ChromePhpHandler',
-            'debug' => 'Symfony\Bridge\Monolog\Handler\DebugHandler',
             'swift_mailer' => 'Symfony\Bridge\Monolog\Handler\SwiftMailerHandler',
             'native_mailer' => 'Monolog\Handler\NativeMailerHandler',
             'socket' => 'Monolog\Handler\SocketHandler',

DependencyInjection/MonologExtension.php

@@ -18,7 +18,6 @@
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Bundle\MonologBundle\DependencyInjection\Compiler\LoggerChannelPass;
-use Symfony\Bundle\MonologBundle\DependencyInjection\Compiler\DebugHandlerPass;
 use Symfony\Bundle\MonologBundle\DependencyInjection\Compiler\AddProcessorsPass;
 use Symfony\Bundle\MonologBundle\DependencyInjection\Compiler\FixEmptyLoggerPass;
 
@@ -34,9 +33,6 @@ public function build(ContainerBuilder $container)
         parent::build($container);
 
         $container->addCompilerPass($channelPass = new LoggerChannelPass());
-        if (!class_exists('Symfony\Bridge\Monolog\Processor\DebugProcessor')) {
-            $container->addCompilerPass(new DebugHandlerPass($channelPass));
-        }
         $container->addCompilerPass(new FixEmptyLoggerPass($channelPass));
         $container->addCompilerPass(new AddProcessorsPass());
         $container->addCompilerPass(new AddSwiftMailerTransportPass());

MonologBundle.php

@@ -166,18 +166,6 @@ public function testExceptionWhenUsingServiceWithoutId()
         $loader->load(array(array('handlers' => array('main' => array('type' => 'service')))), $container);
     }
 
-    /**
-     * @expectedException Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
-     */
-    public function testExceptionWhenUsingDebugName()
-    {
-        // logger
-        $container = new ContainerBuilder();
-        $loader = new MonologExtension();
-
-        $loader->load(array(array('handlers' => array('debug' => array('type' => 'stream')))), $container);
-    }
-
     public function testSyslogHandlerWithLogopts()
     {
         $container = $this->getContainer(array(array('handlers' => array('main' => array('type' => 'syslog', 'logopts' => LOG_CONS)))));