No client instantiation in extension

Author: cevou

DependencyInjection/MonologExtension.php

@@ -296,15 +296,17 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler
             break;
 
         case 'raven':
-            if (class_exists("Raven_Client")) {
-                $definition->setArguments(array(
-                    new \Raven_Client($handler['dsn']),
-                    $handler['level'],
-                    $handler['bubble'],
-                ));
-            } else {
-                throw new InvalidConfigurationException("raven/raven not installed");
-            }
+            $client = new Definition("Raven_Client", array(
+                $handler['dsn']
+            ));
+            $client->setPublic(false);
+            $clientId = 'monolog.raven.client';
+            $container->setDefinition($clientId, $client);
+            $definition->setArguments(array(
+                new Reference($clientId),
+                $handler['level'],
+                $handler['bubble'],
+            ));
             break;
 
         // Handlers using the constructor of AbstractHandler without adding their own arguments

Tests/DependencyInjection/MonologExtensionTest.php

@@ -194,7 +194,6 @@ public function testRavenHandler()
 
         $handler = $container->getDefinition('monolog.handler.raven');
         $this->assertDICDefinitionClass($handler, '%monolog.handler.raven.class%');
-        $this->assertDICConstructorArguments($handler, array(new \Raven_Client($dsn), \Monolog\Logger::DEBUG, true));
     }
 
     protected function getContainer(array $config = array())