Skip to content

Commit 45f5e4f

Browse files
committed
Merge branch '2.3' into 2.4
* 2.3: fixed CS [Process] fixed some volatile tests [HttpKernel] fixed a volatile test [HttpFoundation] fixed some volatile tests Use getPathname() instead of string casting to get BinaryFileReponse file path Conflicts: src/Symfony/Bundle/FrameworkBundle/Command/ConfigDumpReferenceCommand.php src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php src/Symfony/Bundle/FrameworkBundle/EventListener/SessionListener.php src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php src/Symfony/Component/ClassLoader/Tests/ApcUniversalClassLoaderTest.php src/Symfony/Component/Config/Definition/ReferenceDumper.php src/Symfony/Component/Config/Tests/Definition/Dumper/YamlReferenceDumperTest.php src/Symfony/Component/Console/Application.php src/Symfony/Component/Console/Tests/ApplicationTest.php src/Symfony/Component/Filesystem/Exception/IOException.php src/Symfony/Component/Form/Extension/Templating/TemplatingExtension.php src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php src/Symfony/Component/HttpKernel/Tests/Bundle/BundleTest.php src/Symfony/Component/HttpKernel/Tests/Fragment/RoutableFragmentRendererTest.php src/Symfony/Component/HttpKernel/Tests/Profiler/Mock/RedisMock.php src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php src/Symfony/Component/PropertyAccess/PropertyAccessor.php src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorCollectionTest.php src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php src/Symfony/Component/Routing/Matcher/Dumper/ApacheMatcherDumper.php src/Symfony/Component/Routing/Tests/Annotation/RouteTest.php src/Symfony/Component/Routing/Tests/Loader/AnnotationClassLoaderTest.php src/Symfony/Component/Serializer/Encoder/XmlEncoder.php src/Symfony/Component/Validator/Constraints/CollectionValidator.php src/Symfony/Component/Validator/Tests/ExecutionContextTest.php
2 parents 6ac54d4 + f49b4f0 commit 45f5e4f

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

Tests/OptionsResolverTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ public function testResolveWithoutOptionSucceedsIfRequiredAndDefaultValue()
623623
));
624624

625625
$this->assertEquals(array(
626-
'foo' => 'bar'
626+
'foo' => 'bar',
627627
), $this->resolver->resolve(array()));
628628
}
629629

@@ -637,7 +637,7 @@ public function testResolveWithoutOptionSucceedsIfDefaultValueAndRequired()
637637
));
638638

639639
$this->assertEquals(array(
640-
'foo' => 'bar'
640+
'foo' => 'bar',
641641
), $this->resolver->resolve(array()));
642642
}
643643

@@ -652,7 +652,7 @@ public function testResolveSucceedsIfOptionRequiredAndValueAllowed()
652652

653653
$options = array(
654654
'one' => '1',
655-
'two' => '2'
655+
'two' => '2',
656656
);
657657

658658
$this->assertEquals($options, $this->resolver->resolve($options));

Tests/OptionsTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ public function testReplaceClearsAndSets()
372372
'two' => '2',
373373
'three' => function (Options $options) {
374374
return '2' === $options['two'] ? '3' : 'foo';
375-
}
375+
},
376376
));
377377

378378
$this->assertEquals(array(
@@ -389,7 +389,6 @@ public function testClearRemovesAllOptions()
389389
$this->options->clear();
390390

391391
$this->assertEmpty($this->options->all());
392-
393392
}
394393

395394
/**

0 commit comments

Comments
 (0)