Skip to content

Commit 7e55b82

Browse files
Remove deprecated code paths that trigger a runtime notice
1 parent d3342e9 commit 7e55b82

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CHANGELOG
22
=========
33

4+
5.0.0
5+
-----
6+
7+
* added argument `$triggerDeprecation` to `OptionsResolver::offsetGet()`
8+
49
4.3.0
510
-----
611

OptionsResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,7 @@ public function resolve(array $options = [])
828828
* Returns the resolved value of an option.
829829
*
830830
* @param string $option The option name
831-
* @param bool $triggerDeprecation Whether to trigger the deprecation or not (true by default)
831+
* @param bool $triggerDeprecation Whether to trigger the deprecation or not
832832
*
833833
* @return mixed The option value
834834
*
@@ -840,7 +840,7 @@ public function resolve(array $options = [])
840840
* @throws OptionDefinitionException If there is a cyclic dependency between
841841
* lazy options and/or normalizers
842842
*/
843-
public function offsetGet($option/*, bool $triggerDeprecation = true*/)
843+
public function offsetGet($option, bool $triggerDeprecation = true)
844844
{
845845
if (!$this->locked) {
846846
throw new AccessException('Array access is only supported within closures of lazy options and normalizers.');

0 commit comments

Comments
 (0)