Commit 48780e2
committed
bug #515 Fix constants being redefined in PHP 8.4 polyfill (cs278)
This PR was squashed before being merged into the 1.x branch.
Discussion
----------
Fix constants being redefined in PHP 8.4 polyfill
Tracked down this error to this library:
```
In bootstrap.php line 19:
[ErrorException]
Constant CURL_HTTP_VERSION_3 already defined
```
It appears to me the standard is to conditionally define symbols so these two were missing a check. I've also added a basic test which should prevent this happening again.
Commits
-------
230379b Fix constants being redefined in PHP 8.4 polyfill2 files changed
+32
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
20 | 22 | | |
21 | | - | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
0 commit comments