bug #426 add mb_check_encoding with array value (jeremyFreeAgent)

This PR was squashed before being merged into the 1.28-dev branch.

Discussion
----------

add mb_check_encoding with array value

I tried to address the #422 issue.

First time on that project. I'm not sure about what I've done because I'm afraid we cannot do anything for PHP <7.2.

Commits
-------

970d030 add mb_check_encoding with array value

Author: nicolas-grekas

src/Mbstring/Mbstring.php

@@ -406,14 +406,34 @@ public static function mb_encoding_aliases($encoding)
 
     public static function mb_check_encoding($var = null, $encoding = null)
     {
+        if (PHP_VERSION_ID < 70200 && \is_array($var)) {
+            trigger_error('mb_check_encoding() expects parameter 1 to be string, array given', \E_USER_WARNING);
+
+            return null;
+        }
+
         if (null === $encoding) {
             if (null === $var) {
                 return false;
             }
             $encoding = self::$internalEncoding;
         }
 
-        return self::mb_detect_encoding($var, [$encoding]) || false !== @iconv($encoding, $encoding, $var);
+        if (!\is_array($var)) {
+            return self::mb_detect_encoding($var, [$encoding]) || false !== @iconv($encoding, $encoding, $var);
+        }
+
+        foreach ($var as $key => $value) {
+            if (!self::mb_check_encoding($key, $encoding)) {
+                return false;
+            }
+            if (!self::mb_check_encoding($value, $encoding)) {
+                return false;
+            }
+        }
+
+        return true;
+
     }
 
     public static function mb_detect_encoding($str, $encodingList = null, $strict = false)

tests/Mbstring/MbstringTest.php

@@ -466,6 +466,53 @@ public function testCheckEncoding()
         $this->assertTrue(mb_check_encoding("\xE9", 'Windows-1252'));
     }
 
+    /**
+     * @covers \Symfony\Polyfill\Mbstring\Mbstring::mb_check_encoding
+     *
+     * @requires PHP 7.2
+     */
+    public function testCheckEncodingWithArrayValue()
+    {
+        $this->assertTrue(mb_check_encoding(['aςσb'], 'UTF8'));
+        $this->assertTrue(mb_check_encoding(['abc'], 'ASCII'));
+        $this->assertTrue(mb_check_encoding(["\xE9"], 'Windows-1252'));
+
+        $this->assertTrue(mb_check_encoding(['aςσb', 'abc'], 'UTF8'));
+        $this->assertTrue(mb_check_encoding(["\xE9", 'abc'], 'Windows-1252'));
+
+        $this->assertFalse(mb_check_encoding(['aςσb', "\xE9"], 'UTF8'));
+        $this->assertFalse(mb_check_encoding(['abc', "\xE9"], 'ASCII'));
+        $this->assertFalse(mb_check_encoding(['abc', 'aςσb'], 'ASCII'));
+
+        $this->assertTrue(mb_check_encoding(["\xE9" => "\xE9", 'abc' => 'abc'], 'Windows-1252'));
+        $this->assertTrue(mb_check_encoding(['aςσb' => 'aςσb', 'abc' => 'abc'], 'UTF8'));
+
+        $this->assertFalse(mb_check_encoding(['aςσb' => 'aςσb', "\xE9" => 'abc'], 'UTF8'));
+
+
+        $this->assertTrue(mb_check_encoding(['aςσb' => 'aςσb', 'abc' => ['abc', 'aςσb']], 'UTF8'));
+        $this->assertTrue(mb_check_encoding(['aςσb' => 'aςσb', 'abc' => ['abc' => 'abc', 'aςσb' => 'aςσb']], 'UTF8'));
+
+
+        $this->assertFalse(mb_check_encoding(['aςσb' => 'aςσb', 'abc' => ['abc' => 'abc', 'aςσb' => "\xE9"]], 'UTF8'));
+        $this->assertFalse(mb_check_encoding(['aςσb' => 'aςσb', 'abc' => ['abc' => 'abc', "\xE9" => 'aςσb']], 'UTF8'));
+    }
+
+    /**
+     * @covers \Symfony\Polyfill\Mbstring\Mbstring::mb_check_encoding
+     *
+     * @requires PHP < 7.2
+     */
+    public function testCheckEncodingWithArrayValueForPhpLessThan72()
+    {
+        $errorMessage = null;
+        set_error_handler(function ($type, $msg, $file, $line) use (&$errorMessage) { $errorMessage = \E_USER_WARNING === $type || \E_WARNING === $type ? $msg : null; });
+        $this->assertNull(mb_check_encoding(['aςσb'], 'UTF8'));
+        restore_error_handler();
+        $this->assertSame('mb_check_encoding() expects parameter 1 to be string, array given', $errorMessage);
+    }
+
+
     /**
      * @covers \Symfony\Polyfill\Mbstring\Mbstring::mb_detect_encoding
      */