Update Attribute::class constants to PHP 8.5 values
#538
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 29, 2025
xabbuh
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
I had considered sending a patch like this, but decided against it
- PHP 7.4 code with polyfill: Attribute::TARGET_ALL is 127
- PHP 8.0-8.4 code: Attribute::TARGET_ALL is 63
- PHP 8.5: Attribute::TARGET_ALL is 127
Which to me would be confusing. I would expect a PHP 8.0 polyfill to polyfill the class as it existed in PHP 8.0. It is also worth pointing out that for TARGET_CONSTANT, actually trying to put attributes on constants was a parser error until 8.5, so it isn't really useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537