[Routing] Remove @final annotation from Route attribute

To be able to create a custom attribute containing application or section level defaults, the final annotation is removed from the Route attribute.

Fixes #53467

Author: tjveldhuizen

Attribute/Route.php

@@ -20,8 +20,6 @@
  *
  * @author Fabien Potencier <[email protected]>
  * @author Alexander M. Turek <[email protected]>
- *
- * @final since Symfony 6.4
  */
 #[\Attribute(\Attribute::IS_REPEATABLE | \Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD)]
 class Route

Tests/Fixtures/AttributeFixtures/ExtendedRoute.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures;
+
+use Symfony\Component\Routing\Attribute\Route;
+
+#[\Attribute(\Attribute::IS_REPEATABLE | \Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD)]
+class ExtendedRoute extends Route
+{
+    public function __construct(array|string $path = null, ?string $name = null, array $defaults = []) {
+        parent::__construct("/{section<(foo|bar|baz)>}" . $path, $name, [], [], array_merge(['section' => 'foo'], $defaults));
+    }
+}

Tests/Fixtures/AttributeFixtures/ExtendedRouteOnClassController.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures;
+
+use Symfony\Component\Routing\Attribute\Route;
+
+#[ExtendedRoute('/class-level')]
+class ExtendedRouteOnClassController
+{
+    #[Route(path: '/method-level', name: 'action')]
+    public function action()
+    {
+    }
+}

Tests/Fixtures/AttributeFixtures/ExtendedRouteOnMethodController.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures;
+
+class ExtendedRouteOnMethodController
+{
+    #[ExtendedRoute(path: '/method-level', name: 'action')]
+    public function action()
+    {
+    }
+}

Tests/Loader/AttributeClassLoaderTestCase.php

@@ -16,6 +16,8 @@
 use Symfony\Component\Routing\Alias;
 use Symfony\Component\Routing\Loader\AttributeClassLoader;
 use Symfony\Component\Routing\Tests\Fixtures\AnnotationFixtures\AbstractClassController;
+use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\ExtendedRouteOnClassController;
+use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\ExtendedRouteOnMethodController;
 
 abstract class AttributeClassLoaderTestCase extends TestCase
 {
@@ -312,5 +314,21 @@ public function testMethodsAndSchemes()
         $this->assertSame(['https'], $routes->get('string')->getSchemes());
     }
 
+    public function testLoadingExtendedRouteOnClass()
+    {
+        $routes = $this->loader->load(ExtendedRouteOnClassController::class);
+        $this->assertCount(1, $routes);
+        $this->assertSame('/{section}/class-level/method-level', $routes->get('action')->getPath());
+        $this->assertSame(['section' => 'foo'], $routes->get('action')->getDefaults());
+    }
+
+    public function testLoadingExtendedRouteOnMethod()
+    {
+        $routes = $this->loader->load(ExtendedRouteOnMethodController::class);
+        $this->assertCount(1, $routes);
+        $this->assertSame('/{section}/method-level', $routes->get('action')->getPath());
+        $this->assertSame(['section' => 'foo'], $routes->get('action')->getDefaults());
+    }
+
     abstract protected function getNamespace(): string;
 }