[Config][Routing] Fix exclude option being ignored for non-glob and PSR-4 resources

Author: NeilPeyssard

Loader/Psr4DirectoryLoader.php

@@ -38,12 +38,13 @@ public function __construct(
      */
     public function load(mixed $resource, ?string $type = null): ?RouteCollection
     {
+        $excluded = $resource['_excluded'] ?? [];
         $path = $this->locator->locate($resource['path'], $this->currentDirectory);
         if (!is_dir($path)) {
             return new RouteCollection();
         }
 
-        return $this->loadFromDirectory($path, trim($resource['namespace'], '\\'));
+        return $this->loadFromDirectory($path, trim($resource['namespace'], '\\'), $excluded);
     }
 
     public function supports(mixed $resource, ?string $type = null): bool
@@ -59,7 +60,7 @@ public function forDirectory(string $currentDirectory): static
         return $loader;
     }
 
-    private function loadFromDirectory(string $directory, string $psr4Prefix): RouteCollection
+    private function loadFromDirectory(string $directory, string $psr4Prefix, array $excluded = []): RouteCollection
     {
         $collection = new RouteCollection();
         $collection->addResource(new DirectoryResource($directory, '/\.php$/'));
@@ -74,8 +75,13 @@ private function loadFromDirectory(string $directory, string $psr4Prefix): Route
 
         /** @var \SplFileInfo $file */
         foreach ($files as $file) {
+            $normalizedPath = rtrim(str_replace('\\', '/', $file->getPathname()), '/');
+            if (isset($excluded[$normalizedPath])) {
+                continue;
+            }
+
             if ($file->isDir()) {
-                $collection->addCollection($this->loadFromDirectory($file->getPathname(), $psr4Prefix.'\\'.$file->getFilename()));
+                $collection->addCollection($this->loadFromDirectory($file->getPathname(), $psr4Prefix.'\\'.$file->getFilename(), $excluded));
 
                 continue;
             }

Tests/Loader/Psr4DirectoryLoaderTest.php

@@ -65,6 +65,38 @@ public function testAbstractController()
         $this->assertSame(MyChildController::class.'::someAction', $route->getDefault('_controller'));
     }
 
+    public function testExcludeSubNamespace()
+    {
+        $fixturesPath = \dirname(__DIR__).'/Fixtures';
+        $excluded = [
+            rtrim(str_replace('\\', '/', $fixturesPath.'/Psr4Controllers/SubNamespace'), '/') => true,
+        ];
+        $collection = $this->getLoader()->load(
+            ['path' => 'Psr4Controllers', 'namespace' => 'Symfony\Component\Routing\Tests\Fixtures\Psr4Controllers', '_excluded' => $excluded],
+            'attribute'
+        );
+
+        $this->assertNotNull($collection->get('my_route'));
+        $this->assertNull($collection->get('my_other_controller_one'));
+        $this->assertNull($collection->get('my_controller_with_a_trait'));
+        $this->assertNull($collection->get('my_child_controller_from_abstract'));
+    }
+
+    public function testExcludeSingleFile()
+    {
+        $fixturesPath = \dirname(__DIR__).'/Fixtures';
+        $excluded = [
+            rtrim(str_replace('\\', '/', $fixturesPath.'/Psr4Controllers/MyController.php'), '/') => true,
+        ];
+        $collection = $this->getLoader()->load(
+            ['path' => 'Psr4Controllers', 'namespace' => 'Symfony\Component\Routing\Tests\Fixtures\Psr4Controllers', '_excluded' => $excluded],
+            'attribute'
+        );
+
+        $this->assertNull($collection->get('my_route'));
+        $this->assertNotNull($collection->get('my_other_controller_one'));
+    }
+
     /**
      * @dataProvider provideNamespacesThatNeedTrimming
      */