Skip to content

Commit 9d31989

Browse files
Merge branch '3.4'
* 3.4: [3.4] Remove useless docblocks [3.3] More docblock fixes [2.7] More docblock fixes [TwigBridge] Fix BC break due required twig environment Random fixes Docblock fixes [DI] Fix cannot bind env var Fix some signatures in PHP-DSLs [HttpKernel] Enhance deprecation message bumped Symfony version to 3.4.0 updated VERSION for 3.4.0-BETA3 updated CHANGELOG for 3.4.0-BETA3 [SecurityBundle] Fix the datacollector to properly support decision.object being null
2 parents a031adc + 78e46a2 commit 9d31989

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

Loader/Configurator/Traits/RouteTrait.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ trait RouteTrait
2424
/**
2525
* Adds defaults.
2626
*
27-
* @param array $defaults
28-
*
2927
* @return $this
3028
*/
3129
final public function defaults(array $defaults)
@@ -38,8 +36,6 @@ final public function defaults(array $defaults)
3836
/**
3937
* Adds requirements.
4038
*
41-
* @param array $requirements
42-
*
4339
* @return $this
4440
*/
4541
final public function requirements(array $requirements)
@@ -52,8 +48,6 @@ final public function requirements(array $requirements)
5248
/**
5349
* Adds options.
5450
*
55-
* @param array $options
56-
*
5751
* @return $this
5852
*/
5953
final public function options(array $options)

RouteCompiler.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,6 @@ private static function compilePattern(Route $route, $pattern, $isHost)
231231
/**
232232
* Determines the longest static prefix possible for a route.
233233
*
234-
* @param Route $route
235-
* @param array $tokens
236-
*
237234
* @return string The leading static part of a route's path
238235
*/
239236
private static function determineStaticPrefix(Route $route, array $tokens)

Tests/CompiledRouteTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class CompiledRouteTest extends TestCase
1818
{
1919
public function testAccessors()
2020
{
21-
$compiled = new CompiledRoute('prefix', 'regex', array('tokens'), array(), array(), array(), array(), array('variables'));
21+
$compiled = new CompiledRoute('prefix', 'regex', array('tokens'), array(), null, array(), array(), array('variables'));
2222
$this->assertEquals('prefix', $compiled->getStaticPrefix(), '__construct() takes a static prefix as its second argument');
2323
$this->assertEquals('regex', $compiled->getRegex(), '__construct() takes a regexp as its third argument');
2424
$this->assertEquals(array('tokens'), $compiled->getTokens(), '__construct() takes an array of tokens as its fourth argument');

0 commit comments

Comments
 (0)