minor #12529 [2.3] Remove possible call_user_func() (nicolas-grekas)

fabpot · fabpot · commit 7393b7ebc301 · 2014-12-11T19:57:00.000+01:00
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] Remove possible call_user_func()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Merging this in 2.3 enhances performance a bit, but more importantly will ease future merges into 3.0.

Commits
-------

fad7aba [2.3] Remove possible call_user_func()
diff --git a/Tests/Functional/app/AppKernel.php b/Tests/Functional/app/AppKernel.php
@@ -105,7 +105,8 @@ public function serialize()
 
     public function unserialize($str)
     {
-        call_user_func_array(array($this, '__construct'), unserialize($str));
+        $a = unserialize($str);
+        $this->__construct($a[0], $a[1], $a[2], $a[3]);
     }
 
     protected function getKernelParameters()

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,8 @@ public function serialize()`
`105`	`105`
`106`	`106`	`public function unserialize($str)`
`107`	`107`	`{`
`108`		`- call_user_func_array(array($this, '__construct'), unserialize($str));`
	`108`	`+ $a = unserialize($str);`
	`109`	`+ $this->__construct($a[0], $a[1], $a[2], $a[3]);`
`109`	`110`	`}`
`110`	`111`
`111`	`112`	`protected function getKernelParameters()`