[SecurityBundle] Deprecate public services to private

Author: fancyweb

CHANGELOG.md

@@ -16,6 +16,7 @@ CHANGELOG
    use `security.password_hasher_factory` and `Symfony\Component\PasswordHasher\Hasher\PasswordHasherFactoryInterface` instead
  * Deprecate the `security.user_password_encoder.generic` service, the `security.password_encoder` and the `Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface` aliases,
    use `security.user_password_hasher`, `security.password_hasher` and `Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface` instead
+ * Deprecate the public `security.authorization_checker` and `security.token_storage` services to private
 
 5.2.0
 -----

Resources/config/security.php

@@ -68,6 +68,7 @@
                 service('security.access.decision_manager'),
                 param('security.access.always_authenticate_before_granting'),
             ])
+            ->tag('container.private', ['package' => 'symfony/security-bundle', 'version' => '5.3'])
         ->alias(AuthorizationCheckerInterface::class, 'security.authorization_checker')
 
         ->set('security.token_storage', UsageTrackingTokenStorage::class)
@@ -80,6 +81,7 @@
             ])
             ->tag('kernel.reset', ['method' => 'disableUsageTracking'])
             ->tag('kernel.reset', ['method' => 'setToken'])
+            ->tag('container.private', ['package' => 'symfony/security-bundle', 'version' => '5.3'])
         ->alias(TokenStorageInterface::class, 'security.token_storage')
 
         ->set('security.untracked_token_storage', TokenStorage::class)

Tests/Functional/SecurityTest.php

@@ -28,7 +28,7 @@ public function testServiceIsFunctional()
         // put a token into the storage so the final calls can function
         $user = new InMemoryUser('foo', 'pass');
         $token = new UsernamePasswordToken($user, '', 'provider', ['ROLE_USER']);
-        $container->get('security.token_storage')->setToken($token);
+        $container->get('security.token_storage.alias')->setToken($token);
 
         $security = $container->get('functional_test.security.helper');
         $this->assertTrue($security->isGranted('ROLE_USER'));

Tests/Functional/app/SecurityHelper/config.yml

@@ -7,6 +7,10 @@ services:
         alias: security.helper
         public: true
 
+    functional.test.security.token_storage:
+        alias: security.token_storage
+        public: true
+
 security:
     providers:
         in_memory: