minor #32786 add parameter type declarations to private methods (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

add parameter type declarations to private methods

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

1b2aaa4a06 add parameter type declarations to private methods

Author: fabpot

Encoder/Argon2iPasswordEncoder.php

@@ -102,12 +102,12 @@ public function isPasswordValid($encoded, $raw, $salt)
         throw new \LogicException('Argon2i algorithm is not supported. Please install the libsodium extension or upgrade to PHP 7.2+.');
     }
 
-    private function encodePasswordNative($raw)
+    private function encodePasswordNative(string $raw)
     {
         return password_hash($raw, \PASSWORD_ARGON2I, $this->config);
     }
 
-    private function encodePasswordSodiumFunction($raw)
+    private function encodePasswordSodiumFunction(string $raw)
     {
         $hash = sodium_crypto_pwhash_str(
             $raw,
@@ -119,7 +119,7 @@ private function encodePasswordSodiumFunction($raw)
         return $hash;
     }
 
-    private function encodePasswordSodiumExtension($raw)
+    private function encodePasswordSodiumExtension(string $raw)
     {
         $hash = \Sodium\crypto_pwhash_str(
             $raw,

Encoder/EncoderFactory.php

@@ -82,7 +82,7 @@ private function createEncoder(array $config)
         return $reflection->newInstanceArgs($config['arguments']);
     }
 
-    private function getEncoderConfigFromAlgorithm($config)
+    private function getEncoderConfigFromAlgorithm(array $config)
     {
         if ('auto' === $config['algorithm']) {
             $encoderChain = [];

User/InMemoryUserProvider.php

@@ -93,13 +93,11 @@ public function supportsClass($class)
     /**
      * Returns the user by given username.
      *
-     * @param string $username The username
-     *
      * @return User
      *
      * @throws UsernameNotFoundException if user whose given username does not exist
      */
-    private function getUser($username)
+    private function getUser(string $username)
     {
         if (!isset($this->users[strtolower($username)])) {
             $ex = new UsernameNotFoundException(sprintf('Username "%s" does not exist.', $username));

User/LdapUserProvider.php

@@ -140,11 +140,8 @@ protected function loadUser($username, Entry $entry)
 
     /**
      * Fetches a required unique attribute value from an LDAP entry.
-     *
-     * @param Entry|null $entry
-     * @param string     $attribute
      */
-    private function getAttributeValue(Entry $entry, $attribute)
+    private function getAttributeValue(Entry $entry, string $attribute)
     {
         if (!$entry->hasAttribute($attribute)) {
             throw new InvalidArgumentException(sprintf('Missing attribute "%s" for user "%s".', $attribute, $entry->getDn()));