Add return types to internal|final|private methods

Author: nicolas-grekas

Authentication/RememberMe/PersistentToken.php

@@ -49,39 +49,39 @@ public function __construct(string $class, string $username, string $series, str
     /**
      * {@inheritdoc}
      */
-    public function getClass()
+    public function getClass(): string
     {
         return $this->class;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getUsername()
+    public function getUsername(): string
     {
         return $this->username;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getSeries()
+    public function getSeries(): string
     {
         return $this->series;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getTokenValue()
+    public function getTokenValue(): string
     {
         return $this->tokenValue;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getLastUsed()
+    public function getLastUsed(): \DateTime
     {
         return $this->lastUsed;
     }

Authorization/AuthorizationChecker.php

@@ -43,7 +43,7 @@ public function __construct(TokenStorageInterface $tokenStorage, AuthenticationM
      *
      * @throws AuthenticationCredentialsNotFoundException when the token storage has no authentication token
      */
-    final public function isGranted($attributes, $subject = null)
+    final public function isGranted($attributes, $subject = null): bool
     {
         if (null === ($token = $this->tokenStorage->getToken())) {
             throw new AuthenticationCredentialsNotFoundException('The token storage contains no authentication token. One possible reason may be that there is no firewall configured for this URL.');

Authorization/TraceableAccessDecisionManager.php

@@ -48,7 +48,7 @@ public function __construct(AccessDecisionManagerInterface $manager)
     /**
      * {@inheritdoc}
      */
-    public function decide(TokenInterface $token, array $attributes, $object = null)
+    public function decide(TokenInterface $token, array $attributes, $object = null): bool
     {
         $currentDecisionLog = [
             'attributes' => $attributes,
@@ -86,7 +86,7 @@ public function addVoterVote(VoterInterface $voter, array $attributes, int $vote
     /**
      * @return string
      */
-    public function getStrategy()
+    public function getStrategy(): string
     {
         // The $strategy property is misleading because it stores the name of its
         // method (e.g. 'decideAffirmative') instead of the original strategy name
@@ -97,15 +97,15 @@ public function getStrategy()
     /**
      * @return iterable|VoterInterface[]
      */
-    public function getVoters()
+    public function getVoters(): iterable
     {
         return $this->voters;
     }
 
     /**
      * @return array
      */
-    public function getDecisionLog()
+    public function getDecisionLog(): array
     {
         return $this->decisionLog;
     }

Security.php

@@ -61,19 +61,14 @@ public function getUser()
      *
      * @param mixed $attributes
      * @param mixed $subject
-     *
-     * @return bool
      */
-    public function isGranted($attributes, $subject = null)
+    public function isGranted($attributes, $subject = null): bool
     {
         return $this->container->get('security.authorization_checker')
             ->isGranted($attributes, $subject);
     }
 
-    /**
-     * @return TokenInterface|null
-     */
-    public function getToken()
+    public function getToken(): ?TokenInterface
     {
         return $this->container->get('security.token_storage')->getToken();
     }

User/MissingUserProvider.php

@@ -32,23 +32,23 @@ public function __construct(string $firewall)
     /**
      * {@inheritdoc}
      */
-    public function loadUserByUsername($username)
+    public function loadUserByUsername($username): UserInterface
     {
         throw new \BadMethodCallException();
     }
 
     /**
      * {@inheritdoc}
      */
-    public function refreshUser(UserInterface $user)
+    public function refreshUser(UserInterface $user): UserInterface
     {
         throw new \BadMethodCallException();
     }
 
     /**
      * {@inheritdoc}
      */
-    public function supportsClass($class)
+    public function supportsClass($class): bool
     {
         throw new \BadMethodCallException();
     }