Remove unused code and unnecessary else branches

alexandre-daubois · alexandre-daubois · commit 9b1348ac4bc9 · 2024-08-02T08:50:04.000+02:00
diff --git a/User/ChainUserProvider.php b/User/ChainUserProvider.php
@@ -85,9 +85,9 @@ public function refreshUser(UserInterface $user): UserInterface
             $e = new UserNotFoundException(\sprintf('There is no user with name "%s".', $username));
             $e->setUserIdentifier($username);
             throw $e;
-        } else {
-            throw new UnsupportedUserException(\sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', get_debug_type($user)));
         }
+
+        throw new UnsupportedUserException(\sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', get_debug_type($user)));
     }
 
     public function supportsClass(string $class): bool

Original file line number	Diff line number	Diff line change
`@@ -85,9 +85,9 @@ public function refreshUser(UserInterface $user): UserInterface`
`85`	`85`	`$e = new UserNotFoundException(\sprintf('There is no user with name "%s".', $username));`
`86`	`86`	`$e->setUserIdentifier($username);`
`87`	`87`	`throw $e;`
`88`		`- } else {`
`89`		`- throw new UnsupportedUserException(\sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', get_debug_type($user)));`
`90`	`88`	`}`
	`89`	`+`
	`90`	`+ throw new UnsupportedUserException(\sprintf('There is no user provider for user "%s". Shouldn\'t the "supportsClass()" method of your user provider return true for this classname?', get_debug_type($user)));`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`public function supportsClass(string $class): bool`