minor #13206 [2.3] Cleanup deprecations (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] Cleanup deprecations

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | let's see
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

d649bef [2.3] Remove useless tests skips
1d68ad3 [2.3] Cleanup deprecations

Author: fabpot

Tests/Acl/Dbal/AclProviderBenchmarkTest.php

@@ -32,10 +32,6 @@ class AclProviderBenchmarkTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        if (!class_exists('Doctrine\DBAL\DriverManager')) {
-            $this->markTestSkipped('The "Doctrine DBAL" library is not available');
-        }
-
         try {
             $this->con = DriverManager::getConnection(array(
                 'driver' => 'pdo_mysql',

Tests/Acl/Dbal/AclProviderTest.php

@@ -141,9 +141,6 @@ public function testFindAcl()
 
     protected function setUp()
     {
-        if (!class_exists('Doctrine\DBAL\DriverManager')) {
-            $this->markTestSkipped('The Doctrine2 DBAL is required for this test');
-        }
         if (!class_exists('PDO') || !in_array('sqlite', \PDO::getAvailableDrivers())) {
             self::markTestSkipped('This test requires SQLite support in your environment');
         }

Tests/Acl/Dbal/MutableAclProviderTest.php

@@ -483,9 +483,6 @@ protected function callMethod($object, $method, array $args)
 
     protected function setUp()
     {
-        if (!class_exists('Doctrine\DBAL\DriverManager')) {
-            $this->markTestSkipped('The Doctrine2 DBAL is required for this test');
-        }
         if (!class_exists('PDO') || !in_array('sqlite', \PDO::getAvailableDrivers())) {
             self::markTestSkipped('This test requires SQLite support in your environment');
         }

Tests/Acl/Domain/AclTest.php

@@ -510,11 +510,4 @@ protected function getAcl()
     {
         return new Acl(1, new ObjectIdentity(1, 'foo'), new PermissionGrantingStrategy(), array(), true);
     }
-
-    protected function setUp()
-    {
-        if (!class_exists('Doctrine\DBAL\DriverManager')) {
-            $this->markTestSkipped('The Doctrine2 DBAL is required for this test');
-        }
-    }
 }

Tests/Acl/Domain/DoctrineAclCacheTest.php

@@ -98,11 +98,4 @@ protected function getCache($cacheDriver = null, $prefix = DoctrineAclCache::PRE
 
         return new DoctrineAclCache($cacheDriver, $this->getPermissionGrantingStrategy(), $prefix);
     }
-
-    protected function setUp()
-    {
-        if (!class_exists('Doctrine\DBAL\DriverManager')) {
-            $this->markTestSkipped('The Doctrine2 DBAL is required for this test');
-        }
-    }
 }

Tests/Acl/Domain/ObjectIdentityTest.php

@@ -85,13 +85,6 @@ public function getCompareData()
                 array(new ObjectIdentity('1', 'bla'), new ObjectIdentity('1', 'blub'), false),
             );
         }
-
-        protected function setUp()
-        {
-            if (!class_exists('Doctrine\DBAL\DriverManager')) {
-                $this->markTestSkipped('The Doctrine2 DBAL is required for this test');
-            }
-        }
     }
 
     class TestDomainObject

Tests/Acl/Domain/PermissionGrantingStrategyTest.php

@@ -183,11 +183,4 @@ protected function getAcl($strategy)
 
         return new Acl($id++, new ObjectIdentity(1, 'Foo'), $strategy, array(), true);
     }
-
-    protected function setUp()
-    {
-        if (!class_exists('Doctrine\DBAL\DriverManager')) {
-            $this->markTestSkipped('The Doctrine2 DBAL is required for this test');
-        }
-    }
 }

Tests/Core/Validator/Constraints/UserPasswordValidatorTest.php

@@ -23,10 +23,6 @@ class UserPasswordValidatorTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        if (false === class_exists('Symfony\Component\Validator\Validator')) {
-            $this->markTestSkipped('The Validator component is required for this test.');
-        }
-
         $this->context = $this->getMock('Symfony\Component\Validator\ExecutionContext', array(), array(), '', false);
     }
 

Tests/Http/AccessMapTest.php

@@ -15,13 +15,6 @@
 
 class AccessMapTest extends \PHPUnit_Framework_TestCase
 {
-    protected function setUp()
-    {
-        if (!class_exists('Symfony\Component\HttpFoundation\Request')) {
-            $this->markTestSkipped('The "HttpFoundation" component is not available');
-        }
-    }
-
     public function testReturnsFirstMatchedPattern()
     {
         $request = $this->getMock('Symfony\Component\HttpFoundation\Request');

Tests/Http/Authentication/DefaultAuthenticationFailureHandlerTest.php

@@ -31,18 +31,6 @@ class DefaultAuthenticationFailureHandlerTest extends \PHPUnit_Framework_TestCas
 
     protected function setUp()
     {
-        if (!class_exists('Symfony\Component\HttpKernel\HttpKernel')) {
-            $this->markTestSkipped('The "HttpKernel" component is not available');
-        }
-
-        if (!class_exists('Symfony\Component\HttpFoundation\Request')) {
-            $this->markTestSkipped('The "HttpFoundation" component is not available');
-        }
-
-        if (!interface_exists('Psr\Log\LoggerInterface')) {
-            $this->markTestSkipped('The "LoggerInterface" is not available');
-        }
-
         $this->httpKernel = $this->getMock('Symfony\Component\HttpKernel\HttpKernelInterface');
         $this->httpUtils = $this->getMock('Symfony\Component\Security\Http\HttpUtils');
         $this->logger = $this->getMock('Psr\Log\LoggerInterface');