[Security] Delete old session on auth strategy migrate

Author: xelaris

Http/Session/SessionAuthenticationStrategy.php

@@ -47,7 +47,7 @@ public function onAuthentication(Request $request, TokenInterface $token)
                 return;
 
             case self::MIGRATE:
-                $request->getSession()->migrate();
+                $request->getSession()->migrate(true);
 
                 return;
 

Tests/Http/Session/SessionAuthenticationStrategyTest.php

@@ -47,7 +47,7 @@ public function testUnsupportedStrategy()
     public function testSessionIsMigrated()
     {
         $session = $this->getMock('Symfony\Component\HttpFoundation\Session\SessionInterface');
-        $session->expects($this->once())->method('migrate');
+        $session->expects($this->once())->method('migrate')->with($this->equalTo(true));
 
         $strategy = new SessionAuthenticationStrategy(SessionAuthenticationStrategy::MIGRATE);
         $strategy->onAuthentication($this->getRequest($session), $this->getToken());