Removed dead code and various cleaning

saro0h · saro0h · commit c58dd27bcc3a · 2015-01-21T21:57:55.000+01:00
diff --git a/Acl/Dbal/MutableAclProvider.php b/Acl/Dbal/MutableAclProvider.php
@@ -853,7 +853,6 @@ private function updateNewFieldAceProperty($name, array $changes)
     {
         $sids = new \SplObjectStorage();
         $classIds = new \SplObjectStorage();
-        $currentIds = array();
         foreach ($changes[1] as $field => $new) {
             for ($i = 0, $c = count($new); $i<$c; $i++) {
                 $ace = $new[$i];
@@ -881,8 +880,6 @@ private function updateNewFieldAceProperty($name, array $changes)
                     $aceIdProperty = new \ReflectionProperty('Symfony\Component\Security\Acl\Domain\Entry', 'id');
                     $aceIdProperty->setAccessible(true);
                     $aceIdProperty->setValue($ace, intval($aceId));
-                } else {
-                    $currentIds[$ace->getId()] = true;
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -853,7 +853,6 @@ private function updateNewFieldAceProperty($name, array $changes)`
`853`	`853`	`{`
`854`	`854`	`$sids = new \SplObjectStorage();`
`855`	`855`	`$classIds = new \SplObjectStorage();`
`856`		`- $currentIds = array();`
`857`	`856`	`foreach ($changes[1] as $field => $new) {`
`858`	`857`	`for ($i = 0, $c = count($new); $i<$c; $i++) {`
`859`	`858`	`$ace = $new[$i];`
`@@ -881,8 +880,6 @@ private function updateNewFieldAceProperty($name, array $changes)`
`881`	`880`	`$aceIdProperty = new \ReflectionProperty('Symfony\Component\Security\Acl\Domain\Entry', 'id');`
`882`	`881`	`$aceIdProperty->setAccessible(true);`
`883`	`882`	`$aceIdProperty->setValue($ace, intval($aceId));`
`884`		`- } else {`
`885`		`- $currentIds[$ace->getId()] = true;`
`886`	`883`	`}`
`887`	`884`	`}`
`888`	`885`	`}`