Skip to content

Commit e0d0295

Browse files
committed
feature #114 Move acorn dependency to devDependency, as it is already bundled in dist files, close #112 (Kocal)
This PR was merged into the main branch. Discussion ---------- Move `acorn` dependency to devDependency, as it is already bundled in dist files, close #112 ``` Package size report =================== Package info for "`@symfony`/[email protected]": 3.1 MB Released: 2025-01-09 07:16:42.242 +0000 UTC (2w5d ago) Downloads last week: 12,772 (21.82%) Estimated traffic last week: 40 GB Subdependencies: 17 Removed dependencies: - [email protected]: 547 kB (17.38%) Downloads last week: 22,267,720 (N/A% from 8.14.0) Downloads last week from "`@symfony`/[email protected]": 12,772 (N/A%) Traffic last week: N/A Traffic from "`@symfony`/[email protected]": 40 GB (N/A%) Subdependencies: 0 (0%) Estimated new statistics: Package size: 3.1 MB → 2.4 MB (74.94%) Subdependencies: 17 → 16 (-1) Traffic with last week's downloads: For current version: 40 GB → 30 GB (10 GB saved) For all versions: 184 GB → 138 GB (46 GB saved) ``` A little disappointed, I thought it would save more bandwidth, but it's still worth it! Commits ------- e174516 Move `acorn` dependency to devDependency, as it is already bundled in dist files, close #112
2 parents 6b1ab20 + e174516 commit e0d0295

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
* Thus having no effects on the `dist/` files, TypeScript `module` is now set to `ESNext`, `moduleResolution` to `NodeNext`, and `target` to `ES2021` by @Kocal in https://github.com/symfony/stimulus-bridge/pull/99
1313
* Upgrade minimum supported `acorn` version to 8.2.0 by @Kocal in https://github.com/symfony/stimulus-bridge/pull/110
1414
* Add support for `loader-utils@^3.0.0` and `schema-utils@^4.0.0` by @Kocal in https://github.com/symfony/stimulus-bridge/pull/111
15+
* Move `acorn` dependency to devDependency, as it is already bundled in dist files, by @Kocal in https://github.com/symfony/stimulus-bridge/pull/114
1516

1617
### Internal
1718

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"dependencies": {
2323
"@hotwired/stimulus-webpack-helpers": "^1.0.1",
2424
"@types/webpack-env": "^1.16.4",
25-
"acorn": "^8.2.0",
2625
"loader-utils": "^2.0.0 || ^3.0.0",
2726
"schema-utils": "^3.0.0 || ^4.0.0"
2827
},
@@ -35,6 +34,7 @@
3534
"@rollup/plugin-typescript": "^12.1.2",
3635
"@symfony/mock-module": "file:test/fixtures/module",
3736
"@symfony/stimulus-testing": "^2.0.0",
37+
"acorn": "^8.2.0",
3838
"babel-jest": "^27.3.1",
3939
"jest": "^27.3.1",
4040
"rolldown": "^1.0.0-beta.3",

pnpm-lock.yaml

Lines changed: 3 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)