You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #13042 [Lock] Default path for FlockStore (Guikingone)
This PR was merged into the 3.4 branch.
Discussion
----------
[Lock] Default path for FlockStore
Hi everyone 👋
As noticed in the source code:
```php
/**
* @param string|null $lockPath the directory to store the lock, defaults to the system's temporary directory
*
* @throws LockStorageException If the lock directory doesn’t exist or is not writable
*/
public function __construct(string $lockPath = null)
{
if (null === $lockPath) {
$lockPath = sys_get_temp_dir();
}
if (!is_dir($lockPath) || !is_writable($lockPath)) {
throw new InvalidArgumentException(sprintf('The directory "%s" is not writable.', $lockPath));
}
$this->lockPath = $lockPath;
}
```
`sys_get_temp_dir` is the default path is null is given in the constructor, could it be a good idea to notice this? 🤔
Commits
-------
efbb0b3 refacto(Lock): FlockStore default path
0 commit comments