[#1920] Modifying the fix to form_collection - previous we were counting the children, which included the child elements *and* the single "Add a tag" link. Subtracting 1 was correct, but wasn't clear. Counting the number of actual form elements is more straightforward, and then we don't need to subtract 1.

Author: weaverryan

cookbook/form/form_collections.rst

@@ -393,9 +393,12 @@ one example:
         // Get the data-prototype explained earlier
         var prototype = collectionHolder.attr('data-prototype');
 
+        // count the current form inputs we have (e.g. 2), use that as the new index (e.g. 2)
+        var newIndex = collectionHolder.find(':input').length;
+
         // Replace '$$name$$' in the prototype's HTML to
-        // instead be a number based on the current collection's length.
-        var newForm = prototype.replace(/\$\$name\$\$/g, collectionHolder.children().length - 1);
+        // instead be a number based on how many items we have
+        var newForm = prototype.replace(/\$\$name\$\$/g, newIndex);
 
         // Display the form in the page in an li, before the "Add a tag" link li
         var $newFormLi = $('<li></li>').append(newForm);