minor #9423 Improve naming in documentation (kunicmarko20)

This PR was merged into the 2.8 branch.

Discussion
----------

Improve naming in documentation

Continuing the #9354, this time on branch 2.8, there weren't a lot of things that needed a change I guess the initial PR got almost everything 😄

Commits
-------

87d9046 improve naming

Author: javiereguiluz

best_practices/business-logic.rst

@@ -211,7 +211,7 @@ looking for mapping information::
      */
     class Post
     {
-        const NUM_ITEMS = 10;
+        const NUMBER_OF_ITEMS = 10;
 
         /**
          * @ORM\Id

best_practices/templates.rst

@@ -107,9 +107,7 @@ Markdown content into HTML::
 
         public function toHtml($text)
         {
-            $html = $this->parser->text($text);
-
-            return $html;
+            return $this->parser->text($text);
         }
     }
 

components/form.rst

@@ -307,7 +307,7 @@ Your integration with the Validation component will look something like this::
     use Symfony\Component\Validator\Validation;
 
     $vendorDirectory = realpath(__DIR__.'/../vendor');
-    $vendorFormDirectory = $vendorDir.'/symfony/form';
+    $vendorFormDirectory = $vendorDirectory.'/symfony/form';
     $vendorValidatorDirectory = $vendorDirectory.'/symfony/validator';
 
     // creates the validator - details will vary

components/serializer.rst

@@ -407,14 +407,14 @@ and :class:`Symfony\\Component\\Serializer\\Normalizer\\PropertyNormalizer`::
 
     $serializer = new Serializer(array($normalizer), array(new JsonEncoder()));
 
-    $obj = new Company();
-    $obj->name = 'Acme Inc.';
-    $obj->address = '123 Main Street, Big City';
+    $company = new Company();
+    $company->name = 'Acme Inc.';
+    $company->address = '123 Main Street, Big City';
 
-    $json = $serializer->serialize($obj, 'json');
+    $json = $serializer->serialize($company, 'json');
     // {"org_name": "Acme Inc.", "org_address": "123 Main Street, Big City"}
-    $objCopy = $serializer->deserialize($json, Company::class, 'json');
-    // Same data as $obj
+    $companyCopy = $serializer->deserialize($json, Company::class, 'json');
+    // Same data as $company
 
 .. _using-camelized-method-names-for-underscored-attributes:
 

console/commands_as_services.rst

@@ -98,7 +98,6 @@ store the default value in some ``%command.default_name%`` parameter::
         {
             // try to avoid work here (e.g. database query)
             // this method is *always* called - see warning below
-            $defaultName = $this->defaultName;
 
             $this
                 ->setName('demo:greet')
@@ -108,7 +107,7 @@ store the default value in some ``%command.default_name%`` parameter::
                     '-n',
                     InputOption::VALUE_REQUIRED,
                     'Who do you want to greet?',
-                    $defaultName
+                    $this->defaultName
                 )
             ;
         }

controller/soap_web_service.rst

@@ -131,7 +131,7 @@ Below is an example calling the service using a `NuSOAP`_ client. This example
 assumes that the ``indexAction()`` in the controller above is accessible via the
 route ``/soap``::
 
-    $soapClient = new \Soapclient('http://example.com/app.php/soap?wsdl');
+    $soapClient = new \SoapClient('http://example.com/app.php/soap?wsdl');
 
     $result = $soapClient->call('hello', array('name' => 'Scott'));
 

event_dispatcher/class_extension.rst

@@ -66,9 +66,9 @@ use this pattern of class extension::
         /**
          * Sets the value to return and stops other listeners from being notified
          */
-        public function setReturnValue($val)
+        public function setReturnValue($returnValue)
         {
-            $this->returnValue = $val;
+            $this->returnValue = $returnValue;
             $this->isProcessed = true;
             $this->stopPropagation();
         }

form/unit_testing.rst

@@ -134,20 +134,20 @@ make sure the ``FormRegistry`` uses the created instance::
 
     class TestedTypeTest extends TypeTestCase
     {
-        private $entityManager;
+        private $objectManager;
 
         protected function setUp()
         {
             // mock any dependencies
-            $this->entityManager = $this->createMock(ObjectManager::class);
+            $this->objectManager = $this->createMock(ObjectManager::class);
 
             parent::setUp();
         }
 
         protected function getExtensions()
         {
             // create a type instance with the mocked dependencies
-            $type = new TestedType($this->entityManager);
+            $type = new TestedType($this->objectManager);
 
             return array(
                 // register the type instances with the PreloadedExtension

routing/custom_route_loader.rst

@@ -98,12 +98,12 @@ and configure the service and method to call:
         // app/config/routing.php
         use Symfony\Component\Routing\RouteCollection;
 
-        $collection = new RouteCollection();
-        $collection->addCollection(
+        $routes = new RouteCollection();
+        $routes->addCollection(
             $loader->import("admin_route_loader:loadRoutes", "service")
         );
 
-        return $collection;
+        return $routes;
 
 In this example, the routes are loaded by calling the ``loadRoutes()`` method of
 the service whose ID is ``admin_route_loader``. Your service doesn't have to

security/custom_authentication_provider.rst

@@ -212,12 +212,12 @@ the ``PasswordDigest`` header value matches with the user's password::
     class WsseProvider implements AuthenticationProviderInterface
     {
         private $userProvider;
-        private $cacheDir;
+        private $cacheDirectory;
 
-        public function __construct(UserProviderInterface $userProvider, $cacheDir)
+        public function __construct(UserProviderInterface $userProvider, $cacheDirectory)
         {
-            $this->userProvider = $userProvider;
-            $this->cacheDir     = $cacheDir;
+            $this->userProvider   = $userProvider;
+            $this->cacheDirectory = $cacheDirectory;
         }
 
         public function authenticate(TokenInterface $token)
@@ -255,16 +255,16 @@ the ``PasswordDigest`` header value matches with the user's password::
             // Validate that the nonce is *not* used in the last 5 minutes
             // if it has, this could be a replay attack
             if (
-                file_exists($this->cacheDir.'/'.md5($nonce))
-                && file_get_contents($this->cacheDir.'/'.md5($nonce)) + 300 > time()
+                file_exists($this->cacheDirectory.'/'.md5($nonce))
+                && file_get_contents($this->cacheDirectory.'/'.md5($nonce)) + 300 > time()
             ) {
                 throw new NonceExpiredException('Previously used nonce detected');
             }
             // If cache directory does not exist we create it
-            if (!is_dir($this->cacheDir)) {
-                mkdir($this->cacheDir, 0777, true);
+            if (!is_dir($this->cacheDirectory)) {
+                mkdir($this->cacheDirectory, 0777, true);
             }
-            file_put_contents($this->cacheDir.'/'.md5($nonce), time());
+            file_put_contents($this->cacheDirectory.'/'.md5($nonce), time());
 
             // Validate Secret
             $expected = base64_encode(sha1(base64_decode($nonce).$created.$secret, true));