[tests] Use @requires annotation when possible

Author: nicolas-grekas

Tests/Dumper/IcuResFileDumperTest.php

@@ -16,12 +16,11 @@
 
 class IcuResFileDumperTest extends \PHPUnit_Framework_TestCase
 {
+    /**
+     * @requires extension mbstring
+     */
     public function testDump()
     {
-        if (!function_exists('mb_convert_encoding')) {
-            $this->markTestSkipped('This test requires mbstring to work.');
-        }
-
         $catalogue = new MessageCatalogue('en');
         $catalogue->add(array('foo' => 'bar'));
 

Tests/Loader/IcuDatFileLoaderTest.php

@@ -14,15 +14,11 @@
 use Symfony\Component\Translation\Loader\IcuDatFileLoader;
 use Symfony\Component\Config\Resource\FileResource;
 
+/**
+ * @requires extension intl
+ */
 class IcuDatFileLoaderTest extends LocalizedTestCase
 {
-    protected function setUp()
-    {
-        if (!extension_loaded('intl')) {
-            $this->markTestSkipped('This test requires intl extension to work.');
-        }
-    }
-
     /**
      * @expectedException \Symfony\Component\Translation\Exception\InvalidResourceException
      */

Tests/Loader/IcuResFileLoaderTest.php

@@ -14,15 +14,11 @@
 use Symfony\Component\Translation\Loader\IcuResFileLoader;
 use Symfony\Component\Config\Resource\DirectoryResource;
 
+/**
+ * @requires extension intl
+ */
 class IcuResFileLoaderTest extends LocalizedTestCase
 {
-    protected function setUp()
-    {
-        if (!extension_loaded('intl')) {
-            $this->markTestSkipped('This test requires intl extension to work.');
-        }
-    }
-
     public function testLoad()
     {
         // resource is build using genrb command

Tests/Loader/LocalizedTestCase.php

@@ -16,7 +16,7 @@ abstract class LocalizedTestCase extends \PHPUnit_Framework_TestCase
     protected function setUp()
     {
         if (!extension_loaded('intl')) {
-            $this->markTestSkipped('The "intl" extension is not available');
+            $this->markTestSkipped('Extension intl is required.');
         }
     }
 }

Tests/Loader/XliffFileLoaderTest.php

@@ -59,12 +59,11 @@ public function testIncompleteResource()
         $this->assertEquals(array('foo' => 'bar', 'extra' => 'extra', 'key' => '', 'test' => 'with'), $catalogue->all('domain1'));
     }
 
+    /**
+     * @requires extension mbstring
+     */
     public function testEncoding()
     {
-        if (!function_exists('iconv') && !function_exists('mb_convert_encoding')) {
-            $this->markTestSkipped('The iconv and mbstring extensions are not available.');
-        }
-
         $loader = new XliffFileLoader();
         $catalogue = $loader->load(__DIR__.'/../fixtures/encoding.xlf', 'en', 'domain1');