Rely on iconv and symfony/polyfill-*

Author: nicolas-grekas

DataCollector/TranslationDataCollector.php

@@ -137,7 +137,7 @@ private function sanitizeString($string, $length = 80)
     {
         $string = trim(preg_replace('/\s+/', ' ', $string));
 
-        if (function_exists('mb_strlen') && false !== $encoding = mb_detect_encoding($string)) {
+        if (false !== $encoding = mb_detect_encoding($string, null, true)) {
             if (mb_strlen($string, $encoding) > $length) {
                 return mb_substr($string, 0, $length - 3, $encoding).'...';
             }

Loader/XliffFileLoader.php

@@ -153,15 +153,7 @@ private function extractXliff2(\DOMDocument $dom, MessageCatalogue $catalogue, $
     private function utf8ToCharset($content, $encoding = null)
     {
         if ('UTF-8' !== $encoding && !empty($encoding)) {
-            if (function_exists('mb_convert_encoding')) {
-                return mb_convert_encoding($content, $encoding, 'UTF-8');
-            }
-
-            if (function_exists('iconv')) {
-                return iconv('UTF-8', $encoding, $content);
-            }
-
-            throw new \RuntimeException('No suitable convert encoding function (use UTF-8 as your encoding or install the iconv or mbstring extension).');
+            return mb_convert_encoding($content, $encoding, 'UTF-8');
         }
 
         return $content;

Tests/Dumper/IcuResFileDumperTest.php

@@ -16,9 +16,6 @@
 
 class IcuResFileDumperTest extends \PHPUnit_Framework_TestCase
 {
-    /**
-     * @requires extension mbstring
-     */
     public function testFormatCatalogue()
     {
         $catalogue = new MessageCatalogue('en');

Tests/Loader/XliffFileLoaderTest.php

@@ -59,9 +59,6 @@ public function testIncompleteResource()
         $this->assertEquals(array('foo' => 'bar', 'extra' => 'extra', 'key' => '', 'test' => 'with'), $catalogue->all('domain1'));
     }
 
-    /**
-     * @requires extension mbstring
-     */
     public function testEncoding()
     {
         $loader = new XliffFileLoader();

composer.json

@@ -16,7 +16,8 @@
         }
     ],
     "require": {
-        "php": ">=5.3.9"
+        "php": ">=5.3.9",
+        "symfony/polyfill-mbstring": "~1.0"
     },
     "require-dev": {
         "symfony/config": "~2.8",