Skip to content

Commit a47785d

Browse files
nicolas-grekasnicolas-grekas
committed
minor #61299 replace PHPUnit annotations with attributes (xabbuh)
This PR was merged into the 7.4 branch. Discussion ---------- replace PHPUnit annotations with attributes | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 982f89c61b9 replace PHPUnit annotations with attributes
2 parents 7a09edd + 04288f6 commit a47785d

18 files changed

+76
-157
lines changed

‎Tests/Command/TranslationLintCommandTest.php‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Command;
1313

14+
use PHPUnit\Framework\Attributes\RequiresPhpExtension;
1415
use PHPUnit\Framework\TestCase;
1516
use Symfony\Component\Console\Application;
1617
use Symfony\Component\Console\Command\Command;
@@ -21,9 +22,7 @@
2122

2223
final class TranslationLintCommandTest extends TestCase
2324
{
24-
/**
25-
* @requires extension intl
26-
*/
25+
#[RequiresPhpExtension('intl')]
2726
public function testLintCorrectTranslations()
2827
{
2928
$translator = new Translator('en');
@@ -62,9 +61,7 @@ public function testLintCorrectTranslations()
6261
$this->assertStringContainsString('[OK] All translations are valid.', $display);
6362
}
6463

65-
/**
66-
* @requires extension intl
67-
*/
64+
#[RequiresPhpExtension('intl')]
6865
public function testLintMalformedIcuTranslations()
6966
{
7067
$translator = new Translator('en');

‎Tests/Command/TranslationPullCommandTest.php‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Command;
1313

14+
use PHPUnit\Framework\Attributes\DataProvider;
15+
use PHPUnit\Framework\Attributes\RequiresPhpExtension;
1416
use Symfony\Component\Console\Application;
1517
use Symfony\Component\Console\Tester\CommandCompletionTester;
1618
use Symfony\Component\Console\Tester\CommandTester;
@@ -456,9 +458,7 @@ public function testPullForceMessages()
456458
, file_get_contents($filenameValidatorsFr));
457459
}
458460

459-
/**
460-
* @requires extension intl
461-
*/
461+
#[RequiresPhpExtension('intl')]
462462
public function testPullForceIntlIcuMessages()
463463
{
464464
$arrayLoader = new ArrayLoader();
@@ -689,9 +689,7 @@ public function testPullMessagesMultipleDomains()
689689
, file_get_contents($filenameDomain));
690690
}
691691

692-
/**
693-
* @dataProvider provideCompletionSuggestions
694-
*/
692+
#[DataProvider('provideCompletionSuggestions')]
695693
public function testComplete(array $input, array $expectedSuggestions)
696694
{
697695
$application = new Application();

‎Tests/Command/TranslationPushCommandTest.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Command;
1313

14+
use PHPUnit\Framework\Attributes\DataProvider;
1415
use Symfony\Component\Console\Application;
1516
use Symfony\Component\Console\Tester\CommandCompletionTester;
1617
use Symfony\Component\Console\Tester\CommandTester;
@@ -373,9 +374,7 @@ public function testPushWithProviderDomains()
373374
$this->assertStringContainsString('[OK] New local translations has been sent to "null" (for "en, fr" locale(s), and "messages" domain(s)).', trim($tester->getDisplay()));
374375
}
375376

376-
/**
377-
* @dataProvider provideCompletionSuggestions
378-
*/
377+
#[DataProvider('provideCompletionSuggestions')]
379378
public function testComplete(array $input, array $expectedSuggestions)
380379
{
381380
$application = new Application();

‎Tests/Command/XliffLintCommandTest.php‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Command;
1313

14+
use PHPUnit\Framework\Attributes\DataProvider;
1415
use PHPUnit\Framework\TestCase;
1516
use Symfony\Component\Console\Application;
1617
use Symfony\Component\Console\Command\Command;
@@ -57,9 +58,7 @@ public function testLintCorrectFiles()
5758
$this->assertStringContainsString('OK', trim($tester->getDisplay()));
5859
}
5960

60-
/**
61-
* @dataProvider provideStrictFilenames
62-
*/
61+
#[DataProvider('provideStrictFilenames')]
6362
public function testStrictFilenames($requireStrictFileNames, $fileNamePattern, $targetLanguage, $mustFail)
6463
{
6564
$tester = $this->createCommandTester($requireStrictFileNames);
@@ -258,9 +257,7 @@ public static function provideStrictFilenames()
258257
yield [true, '%locale%.messages.xlf', 'es', true];
259258
}
260259

261-
/**
262-
* @dataProvider provideCompletionSuggestions
263-
*/
260+
#[DataProvider('provideCompletionSuggestions')]
264261
public function testComplete(array $input, array $expectedSuggestions)
265262
{
266263
$tester = new CommandCompletionTester($this->createCommand());

‎Tests/DependencyInjection/DataCollectorTranslatorPassTest.php‎

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Translation\Tests\DependencyInjection;
1313

14+
use PHPUnit\Framework\Attributes\DataProvider;
1415
use PHPUnit\Framework\TestCase;
1516
use Symfony\Component\DependencyInjection\ContainerBuilder;
1617
use Symfony\Component\DependencyInjection\Reference;
@@ -43,9 +44,7 @@ protected function setUp(): void
4344
;
4445
}
4546

46-
/**
47-
* @dataProvider getImplementingTranslatorBagInterfaceTranslatorClassNames
48-
*/
47+
#[DataProvider('getImplementingTranslatorBagInterfaceTranslatorClassNames')]
4948
public function testProcessKeepsDataCollectorTranslatorIfItImplementsTranslatorBagInterface($class)
5049
{
5150
$this->container->register('translator', $class);
@@ -55,9 +54,7 @@ public function testProcessKeepsDataCollectorTranslatorIfItImplementsTranslatorB
5554
$this->assertTrue($this->container->hasDefinition('translator.data_collector'));
5655
}
5756

58-
/**
59-
* @dataProvider getImplementingTranslatorBagInterfaceTranslatorClassNames
60-
*/
57+
#[DataProvider('getImplementingTranslatorBagInterfaceTranslatorClassNames')]
6158
public function testProcessKeepsDataCollectorIfTranslatorImplementsTranslatorBagInterface($class)
6259
{
6360
$this->container->register('translator', $class);
@@ -75,9 +72,7 @@ public static function getImplementingTranslatorBagInterfaceTranslatorClassNames
7572
];
7673
}
7774

78-
/**
79-
* @dataProvider getNotImplementingTranslatorBagInterfaceTranslatorClassNames
80-
*/
75+
#[DataProvider('getNotImplementingTranslatorBagInterfaceTranslatorClassNames')]
8176
public function testProcessRemovesDataCollectorTranslatorIfItDoesNotImplementTranslatorBagInterface($class)
8277
{
8378
$this->container->register('translator', $class);
@@ -87,9 +82,7 @@ public function testProcessRemovesDataCollectorTranslatorIfItDoesNotImplementTra
8782
$this->assertFalse($this->container->hasDefinition('translator.data_collector'));
8883
}
8984

90-
/**
91-
* @dataProvider getNotImplementingTranslatorBagInterfaceTranslatorClassNames
92-
*/
85+
#[DataProvider('getNotImplementingTranslatorBagInterfaceTranslatorClassNames')]
9386
public function testProcessRemovesDataCollectorIfTranslatorDoesNotImplementTranslatorBagInterface($class)
9487
{
9588
$this->container->register('translator', $class);

‎Tests/Exception/UnsupportedSchemeExceptionTest.php‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Exception;
1313

14+
use PHPUnit\Framework\Attributes\DataProvider;
15+
use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;
1416
use PHPUnit\Framework\TestCase;
1517
use Symfony\Bridge\PhpUnit\ClassExistsMock;
1618
use Symfony\Component\Translation\Bridge\Crowdin\CrowdinProviderFactory;
@@ -20,9 +22,7 @@
2022
use Symfony\Component\Translation\Exception\UnsupportedSchemeException;
2123
use Symfony\Component\Translation\Provider\Dsn;
2224

23-
/**
24-
* @runTestsInSeparateProcesses
25-
*/
25+
#[RunTestsInSeparateProcesses]
2626
final class UnsupportedSchemeExceptionTest extends TestCase
2727
{
2828
public static function setUpBeforeClass(): void
@@ -36,9 +36,7 @@ public static function setUpBeforeClass(): void
3636
]);
3737
}
3838

39-
/**
40-
* @dataProvider messageWhereSchemeIsPartOfSchemeToPackageMapProvider
41-
*/
39+
#[DataProvider('messageWhereSchemeIsPartOfSchemeToPackageMapProvider')]
4240
public function testMessageWhereSchemeIsPartOfSchemeToPackageMap(string $scheme, string $package)
4341
{
4442
$dsn = new Dsn(\sprintf('%s://localhost', $scheme));
@@ -57,9 +55,7 @@ public static function messageWhereSchemeIsPartOfSchemeToPackageMapProvider(): \
5755
yield ['phrase', 'symfony/phrase-translation-provider'];
5856
}
5957

60-
/**
61-
* @dataProvider messageWhereSchemeIsNotPartOfSchemeToPackageMapProvider
62-
*/
58+
#[DataProvider('messageWhereSchemeIsNotPartOfSchemeToPackageMapProvider')]
6359
public function testMessageWhereSchemeIsNotPartOfSchemeToPackageMap(string $expected, Dsn $dsn, ?string $name, array $supported)
6460
{
6561
$this->assertSame(

‎Tests/Extractor/PhpAstExtractorTest.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Extractor;
1313

14+
use PHPUnit\Framework\Attributes\DataProvider;
1415
use PHPUnit\Framework\TestCase;
1516
use Symfony\Component\Translation\Extractor\PhpAstExtractor;
1617
use Symfony\Component\Translation\Extractor\Visitor\ConstraintVisitor;
@@ -22,9 +23,7 @@ final class PhpAstExtractorTest extends TestCase
2223
{
2324
public const OTHER_DOMAIN = 'not_messages';
2425

25-
/**
26-
* @dataProvider resourcesProvider
27-
*/
26+
#[DataProvider('resourcesProvider')]
2827
public function testExtraction(iterable|string $resource)
2928
{
3029
$extractor = new PhpAstExtractor([

‎Tests/Formatter/IntlFormatterTest.php‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,17 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Formatter;
1313

14+
use PHPUnit\Framework\Attributes\DataProvider;
15+
use PHPUnit\Framework\Attributes\RequiresPhpExtension;
16+
use PHPUnit\Framework\TestCase;
1417
use Symfony\Component\Translation\Exception\InvalidArgumentException;
1518
use Symfony\Component\Translation\Formatter\IntlFormatter;
1619
use Symfony\Component\Translation\Formatter\IntlFormatterInterface;
1720

18-
/**
19-
* @requires extension intl
20-
*/
21-
class IntlFormatterTest extends \PHPUnit\Framework\TestCase
21+
#[RequiresPhpExtension('intl')]
22+
class IntlFormatterTest extends TestCase
2223
{
23-
/**
24-
* @dataProvider provideDataForFormat
25-
*/
24+
#[DataProvider('provideDataForFormat')]
2625
public function testFormat($expected, $message, $arguments)
2726
{
2827
$this->assertEquals($expected, trim((new IntlFormatter())->formatIntl($message, 'en', $arguments)));
@@ -90,9 +89,7 @@ public static function provideDataForFormat()
9089
];
9190
}
9291

93-
/**
94-
* @dataProvider percentAndBracketsAreTrimmedProvider
95-
*/
92+
#[DataProvider('percentAndBracketsAreTrimmedProvider')]
9693
public function testPercentsAndBracketsAreTrimmed(string $expected, string $message, array $parameters)
9794
{
9895
$formatter = new IntlFormatter();

‎Tests/Formatter/MessageFormatterTest.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,13 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Formatter;
1313

14+
use PHPUnit\Framework\Attributes\DataProvider;
1415
use PHPUnit\Framework\TestCase;
1516
use Symfony\Component\Translation\Formatter\MessageFormatter;
1617

1718
class MessageFormatterTest extends TestCase
1819
{
19-
/**
20-
* @dataProvider getTransMessages
21-
*/
20+
#[DataProvider('getTransMessages')]
2221
public function testFormat($expected, $message, $parameters = [])
2322
{
2423
$this->assertEquals($expected, $this->getMessageFormatter()->format($message, 'en', $parameters));

‎Tests/Loader/IcuDatFileLoaderTest.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,13 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Loader;
1313

14+
use PHPUnit\Framework\Attributes\RequiresPhpExtension;
1415
use Symfony\Component\Config\Resource\FileResource;
1516
use Symfony\Component\Translation\Exception\InvalidResourceException;
1617
use Symfony\Component\Translation\Exception\NotFoundResourceException;
1718
use Symfony\Component\Translation\Loader\IcuDatFileLoader;
1819

19-
/**
20-
* @requires extension intl
21-
*/
20+
#[RequiresPhpExtension('intl')]
2221
class IcuDatFileLoaderTest extends LocalizedTestCase
2322
{
2423
public function testLoadInvalidResource()

0 commit comments

Comments
 (0)