minor #23216 Remove HHVM support (second edition) (Nek-)

nicolas-grekas · nicolas-grekas · commit a87e0cc0c770 · 2017-07-03T10:26:18.000+03:00
This PR was squashed before being merged into the 4.0-dev branch (closes #23216).

Discussion
----------

Remove HHVM support (second edition)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | not needed

This PR removes HHVM compatiblity following #22758 as some things were missing. It also removes some useless comments.

Commits
-------

471b84c Remove HHVM support (second edition)
diff --git a/Loader/IcuDatFileLoader.php b/Loader/IcuDatFileLoader.php
@@ -39,7 +39,6 @@ public function load($resource, $locale, $domain = 'messages')
         try {
             $rb = new \ResourceBundle($locale, $resource);
         } catch (\Exception $e) {
-            // HHVM compatibility: constructor throws on invalid resource
             $rb = null;
         }
 
diff --git a/Loader/IcuResFileLoader.php b/Loader/IcuResFileLoader.php
@@ -39,7 +39,6 @@ public function load($resource, $locale, $domain = 'messages')
         try {
             $rb = new \ResourceBundle($locale, $resource);
         } catch (\Exception $e) {
-            // HHVM compatibility: constructor throws on invalid resource
             $rb = null;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ public function load($resource, $locale, $domain = 'messages')`
`39`	`39`	`try {`
`40`	`40`	`$rb = new \ResourceBundle($locale, $resource);`
`41`	`41`	`} catch (\Exception $e) {`
`42`		`- // HHVM compatibility: constructor throws on invalid resource`
`43`	`42`	`$rb = null;`
`44`	`43`	`}`
`45`	`44`