Merge branch '3.2'

* 3.2: (51 commits)
  [FrameworkBundle] [Workflow] Fix service marking store configuration
  Fix merge
  [Validator] add class name to the cache key
  [Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize
  Throw less misleading exception when property access not found
  [Twig] Fix deprecations with Twig 1.29
  [FrameworkBundle] Fix validation cache warmer with failing or missing classes
  Fixed typo
  [FrameworkBundle] Removed the kernel.debug parameter from the cache pool namespace seed
  Fix email address
  fix the docblock in regard to the role argument
  [Bridge\Twig] Trigger deprecation when using FormExtension::$renderer
  Don't use the "app" global variable in the profiler
  [VarDumper] fix tests when xdebug is enabled
  Fix merge
  FIXED NON EXISTING TYPE DECLARATION
  [Form] Add failing test for data collector bug
  [Cache] Fix dumping SplDoublyLinkedList iter mode
  [Form] Fix FormDataCollector
  Ignore missing 'debug.file_link_formatter' service in Debug and Twig bundles
  ...

Author: nicolas-grekas

DataCollector/TranslationDataCollector.php

@@ -101,12 +101,12 @@ private function sanitizeCollectedMessages($messages)
 
             if (!isset($result[$messageId])) {
                 $message['count'] = 1;
-                $message['parameters'] = !empty($message['parameters']) ? array($message['parameters']) : array();
+                $message['parameters'] = !empty($message['parameters']) ? array($this->cloneVar($message['parameters'])) : array();
                 $messages[$key]['translation'] = $this->sanitizeString($message['translation']);
                 $result[$messageId] = $message;
             } else {
                 if (!empty($message['parameters'])) {
-                    $result[$messageId]['parameters'][] = $message['parameters'];
+                    $result[$messageId]['parameters'][] = $this->cloneVar($message['parameters']);
                 }
 
                 ++$result[$messageId]['count'];

Tests/DataCollector/TranslationDataCollectorTest.php

@@ -13,6 +13,7 @@
 
 use Symfony\Component\Translation\DataCollectorTranslator;
 use Symfony\Component\Translation\DataCollector\TranslationDataCollector;
+use Symfony\Component\VarDumper\Cloner\VarCloner;
 
 class TranslationDataCollectorTest extends \PHPUnit_Framework_TestCase
 {
@@ -39,6 +40,8 @@ public function testCollectEmptyMessages()
 
     public function testCollect()
     {
+        $cloner = new VarCloner();
+
         $collectedMessages = array(
             array(
                   'id' => 'foo',
@@ -115,9 +118,9 @@ public function testCollect()
                   'state' => DataCollectorTranslator::MESSAGE_MISSING,
                   'count' => 3,
                   'parameters' => array(
-                      array('%count%' => 3),
-                      array('%count%' => 3),
-                      array('%count%' => 4, '%foo%' => 'bar'),
+                      $cloner->cloneVar(array('%count%' => 3)),
+                      $cloner->cloneVar(array('%count%' => 3)),
+                      $cloner->cloneVar(array('%count%' => 4, '%foo%' => 'bar')),
                   ),
                   'transChoiceNumber' => 3,
             ),