[2.6] Static Code Analysis for Components and Bundles

kalessil · fabpot · commit d84291215b58 · 2015-07-08T07:59:48.000+02:00
diff --git a/Loader/JsonFileLoader.php b/Loader/JsonFileLoader.php
@@ -20,7 +20,7 @@
  *
  * @author singles
  */
-class JsonFileLoader extends ArrayLoader implements LoaderInterface
+class JsonFileLoader extends ArrayLoader
 {
     /**
      * {@inheritdoc}
diff --git a/Tests/TranslatorTest.php b/Tests/TranslatorTest.php
@@ -502,7 +502,7 @@ public function testTransChoiceFallbackWithNoTranslation()
     public function testGetMessages($resources, $locale, $expected)
     {
         $locales = array_keys($resources);
-        $_locale = !is_null($locale) ? $locale : reset($locales);
+        $_locale = null !== $locale ? $locale : reset($locales);
         $locales = array_slice($locales, 0, array_search($_locale, $locales));
 
         $translator = new Translator($_locale, new MessageSelector());

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`*`
`21`	`21`	`* @author singles`
`22`	`22`	`*/`
`23`		`-class JsonFileLoader extends ArrayLoader implements LoaderInterface`
	`23`	`+class JsonFileLoader extends ArrayLoader`
`24`	`24`	`{`
`25`	`25`	`/**`
`26`	`26`	`* {@inheritdoc}`
Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@ public function testTransChoiceFallbackWithNoTranslation()`
`502`	`502`	`public function testGetMessages($resources, $locale, $expected)`
`503`	`503`	`{`
`504`	`504`	`$locales = array_keys($resources);`
`505`		`- $_locale = !is_null($locale) ? $locale : reset($locales);`
	`505`	`+ $_locale = null !== $locale ? $locale : reset($locales);`
`506`	`506`	`$locales = array_slice($locales, 0, array_search($_locale, $locales));`
`507`	`507`
`508`	`508`	`$translator = new Translator($_locale, new MessageSelector());`