Skip to content

Commit 18f2cbe

Browse files
committed
Merge branch '5.4' into 6.3
* 5.4: PHP 8.3 highlight_file function output changes
2 parents e5a2bb7 + 8e94856 commit 18f2cbe

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

Extension/CodeExtension.php

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,21 @@ public function fileExcerpt(string $file, int $line, int $srcContext = 3): ?stri
117117
// highlight_file could throw warnings
118118
// see https://bugs.php.net/25725
119119
$code = @highlight_file($file, true);
120-
// remove main code/span tags
121-
$code = preg_replace('#^<code.*?>\s*<span.*?>(.*)</span>\s*</code>#s', '\\1', $code);
122-
// split multiline spans
123-
$code = preg_replace_callback('#<span ([^>]++)>((?:[^<]*+<br \/>)++[^<]*+)</span>#', fn ($m) => "<span $m[1]>".str_replace('<br />', "</span><br /><span $m[1]>", $m[2]).'</span>', $code);
124-
$content = explode('<br />', $code);
120+
if (\PHP_VERSION_ID >= 80300) {
121+
// remove main pre/code tags
122+
$code = preg_replace('#^<pre.*?>\s*<code.*?>(.*)</code>\s*</pre>#s', '\\1', $code);
123+
// split multiline code tags
124+
$code = preg_replace_callback('#<code ([^>]++)>((?:[^<]*+\\n)++[^<]*+)</code>#', fn ($m) => "<code $m[1]>".str_replace("\n", "</code>\n<code $m[1]>", $m[2]).'</code>', $code);
125+
// Convert spaces to html entities to preserve indentation when rendered
126+
$code = str_replace(' ', '&nbsp;', $code);
127+
$content = explode("\n", $code);
128+
} else {
129+
// remove main code/span tags
130+
$code = preg_replace('#^<code.*?>\s*<span.*?>(.*)</span>\s*</code>#s', '\\1', $code);
131+
// split multiline spans
132+
$code = preg_replace_callback('#<span ([^>]++)>((?:[^<]*+<br \/>)++[^<]*+)</span>#', fn ($m) => "<span $m[1]>".str_replace('<br />', "</span><br /><span $m[1]>", $m[2]).'</span>', $code);
133+
$content = explode('<br />', $code);
134+
}
125135

126136
$lines = [];
127137
if (0 > $srcContext) {

0 commit comments

Comments
 (0)